rule implementation fix

Author: yelizhenden-mdb

tools/spectral/ipa/rulesets/functions/createMethodRequestBodyIsGetResponse.js

@@ -2,15 +2,11 @@ import { getResponseOfGetMethodByMediaType, isCustomMethodIdentifier } from './u
 import { resolveObject } from './utils/componentUtils.js';
 import { compareSchemas } from './utils/schemaUtils.js';
 import { hasException } from './utils/exceptions.js';
-import {
-  collectAdoption,
-  collectAndReturnViolation,
-  collectException,
-} from './utils/collectionUtils.js';
+import { collectAdoption, collectAndReturnViolation, collectException } from './utils/collectionUtils.js';
 
 const RULE_NAME = 'xgen-IPA-106-create-method-request-body-is-get-method-response';
-const ERROR_MESSAGE = 'The request body schema properties must match the response body schema properties of the Get method.';
-
+const ERROR_MESSAGE =
+  'The request body schema properties must match the response body schema properties of the Get method.';
 
 export default (input, _, { path, documentInventory }) => {
   const oas = documentInventory.resolved;
@@ -20,10 +16,10 @@ export default (input, _, { path, documentInventory }) => {
     return;
   }
 
-  const contentPerMediaType = resolveObject(oas, path);
+  const postMethodRequestContentPerMediaType = resolveObject(oas, path);
 
-  if (hasException(contentPerMediaType, RULE_NAME)) {
-    collectException(contentPerMediaType, RULE_NAME, path);
+  if (hasException(postMethodRequestContentPerMediaType, RULE_NAME)) {
+    collectException(postMethodRequestContentPerMediaType, RULE_NAME, path);
     return;
   }
 
@@ -33,9 +29,14 @@ export default (input, _, { path, documentInventory }) => {
     return;
   }
 
-  const postMethodRequestContentPerMediaType = resolveObject(oas, path);
-  if (compareSchemas(postMethodRequestContentPerMediaType.schema, getMethodResponseContentPerMediaType.schema)) {
+  const inconsistentFields = compareSchemas(
+    postMethodRequestContentPerMediaType.schema,
+    getMethodResponseContentPerMediaType.schema
+  );
+  if (inconsistentFields.length === 0) {
     collectAdoption(path, RULE_NAME);
+  } else {
+    return collectAndReturnViolation(path, RULE_NAME, ERROR_MESSAGE);
   }
-  return collectAndReturnViolation(path, RULE_NAME, ERROR_MESSAGE);
+
 };