IPA 104 opId tests

Author: Sophia Marie Terry

package.json

@@ -19,8 +19,7 @@
         },
         "testPathIgnorePatterns": [
             "__helpers__",
-            "metrics/data",
-            "IPA\\d+ValidOperationID\\.test\\.js$"
+            "metrics/data"
         ]
     },
     "dependencies": {

tools/spectral/ipa/__tests__/IPA104ValidOperationID.test.js

@@ -1,7 +1,5 @@
 import testRule from './__helpers__/testRule';
-
-// TODO: add tests for xgen-custom-method extension - CLOUDP-306294
-// TOOD: enable tests for invalid methods (after rules are upgraded to warning) - CLOUDP-329722
+import { DiagnosticSeverity } from '@stoplight/types';
 
 testRule('xgen-IPA-104-valid-operation-id', [
   {
@@ -17,40 +15,51 @@ testRule('xgen-IPA-104-valid-operation-id', [
     },
     errors: [],
   },
-  // This test will be enable when the xgen-IPA-104-valid-operation-id is set to warning severity - CLOUDP-329722
-  /* {
-    name: 'invalid methods',
+  {
+    name: 'invalid methods with short opIDs',
     document: {
       paths: {
-        '/api/atlas/v2/groups/{groupId}/accessList/{entryValue}/status': {
-          get: {
-            operationId: 'getProjectIpAccessListStatus',
-          },
-        },
-        '/api/atlas/v2/groups/{groupId}/dataFederation/{tenantName}/limits/{limitName}': {
+        '/api/atlas/v2/groups/{groupId}/accessList/{entryValue}': {
           get: {
-            operationId: 'returnFederatedDatabaseQueryLimit',
+            operationId: 'getProjectIpList',
           },
         },
       },
     },
     errors: [
       {
         code: 'xgen-IPA-104-valid-operation-id',
-        message:
-          'Invalid OperationID. ',
-        path: ['paths', '/api/atlas/v2/groups/{groupId}/accessList/{entryValue}/status', 'get'],
+        message: 'Invalid OperationID. ',
+        path: ['paths', '/api/atlas/v2/groups/{groupId}/accessList/{entryValue}', 'get', 'operationId'],
         severity: DiagnosticSeverity.Warning,
       },
+    ],
+  },
+  {
+    name: 'invalid methods with long opIDs',
+    document: {
+      paths: {
+        '/api/atlas/v2/groups/{groupId}/clusters/{clusterName}/queryShapeInsights/{queryShapeHash}/details': {
+          get: {
+            operationId: 'getShardedClusterBackup',
+          },
+        },
+      },
+    },
+    errors: [
       {
         code: 'xgen-IPA-104-valid-operation-id',
-        message:
-          'Invalid OperationID. ',
-        path: ['paths', '/api/atlas/v2/groups/{groupId}/dataFederation/{tenantName}/limits/{limitName}', 'get'],
+        message: 'Invalid OperationID. ',
+        path: [
+          'paths',
+          '/api/atlas/v2/groups/{groupId}/clusters/{clusterName}/queryShapeInsights/{queryShapeHash}/details',
+          'get',
+          'operationId',
+        ],
         severity: DiagnosticSeverity.Warning,
       },
     ],
-  }, */
+  },
   {
     name: 'invalid methods with exceptions',
     document: {

tools/spectral/ipa/rulesets/IPA-104.yaml

@@ -110,7 +110,7 @@ rules:
         - Generates the expected OperationId given the resource identifier
         - Confirms that the existing operationId is compliant with generated IPA Compliant OperationId
     message: '{{error}} https://mdb.link/mongodb-atlas-openapi-validation#xgen-IPA-104-valid-operation-id'
-    severity: off
+    severity: warn
     given: '#GetOperationObject'
     then:
       function: 'IPA104ValidOperationID'