Apply suggestions from code review

Co-authored-by: Lovisa Berggren <[email protected]>

Author: wtrocki

tools/spectral/ipa/__tests__/deleteMethodResponseShouldNotHaveSchema.test.js

@@ -18,7 +18,7 @@ testRule('xgen-IPA-108-delete-response-should-be-empty', [
     errors: [],
   },
   {
-    name: 'valid DELETE with void 204',
+    name: 'valid DELETE with void 204 versioned',
     document: {
       paths: {
         '/resource/{id}': {
@@ -62,7 +62,7 @@ testRule('xgen-IPA-108-delete-response-should-be-empty', [
       {
         code: 'xgen-IPA-108-delete-response-should-be-empty',
         message:
-          'DELETE method should return an empty response. The response should not have a schema property and reference to models http://go/ipa/108',
+          'DELETE method should return an empty response. The response should not have a schema property and reference to models. http://go/ipa/108',
         path: ['paths', '/resource/{id}', 'delete'],
         severity: DiagnosticSeverity.Warning,
       },

tools/spectral/ipa/rulesets/IPA-108.yaml

@@ -3,7 +3,7 @@
 
 rules:
   xgen-IPA-108-delete-response-should-be-empty:
-    description: Delete method response should not have schema reference to object http://go/ipa/108
+    description: Delete method response should not have schema reference to object. http://go/ipa/108
     message: '{{error}} http://go/ipa/108'
     severity: warn
     given: $.paths[*].delete

tools/spectral/ipa/rulesets/README.md

@@ -46,9 +46,9 @@ For rule definitions, see [IPA-106.yaml](https://github.com/mongodb/openapi/blob
 
 For rule definitions, see [IPA-108.yaml](https://github.com/mongodb/openapi/blob/main/tools/spectral/ipa/rulesets/IPA-108.yaml).
 
-| Rule Name                                    | Description                                                                         | Severity |
-| -------------------------------------------- | ----------------------------------------------------------------------------------- | -------- |
-| xgen-IPA-108-delete-response-should-be-empty | Delete method response should not have schema reference to object http://go/ipa/108 | warn     |
+| Rule Name                                    | Description                                                                          | Severity |
+| -------------------------------------------- | ------------------------------------------------------------------------------------ | -------- |
+| xgen-IPA-108-delete-response-should-be-empty | Delete method response should not have schema reference to object. http://go/ipa/108 | warn     |
 
 ### IPA-109
 

tools/spectral/ipa/rulesets/functions/deleteMethodResponseShouldNotHaveSchema.js

@@ -3,7 +3,7 @@ import { collectAdoption, collectAndReturnViolation, collectException } from './
 
 const RULE_NAME = 'xgen-IPA-108-delete-response-should-be-empty';
 const ERROR_MESSAGE =
-  'DELETE method should return an empty response. The response should not have a schema property and reference to models';
+  'DELETE method should return an empty response. The response should not have a schema property and reference to models.';
 
 /**
  * Delete method should return an empty response