Skip to content

Commit 4ceaa63

Browse files
author
Sophia Marie Terry
committed
Fix version check script to look at HEAD
1 parent b5995b7 commit 4ceaa63

File tree

3 files changed

+9
-17
lines changed

3 files changed

+9
-17
lines changed
Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,12 @@
1-
#!/bin/bash
2-
set -eou pipefail
1+
#!/bin/bash
2+
set -eou pipefail
3+
4+
current_version=$(jq -r '.version' tools/spectral/ipa/package.json)
35

4-
current_version=$(jq -r '.version' tools/spectral/ipa/package.json)
5-
6-
previous_version=$(git show origin/"${BASE_BRANCH}":tools/spectral/ipa/package.json | jq -r '.version')
6+
previous_version=$(git show HEAD^:tools/spectral/ipa/package.json | jq -r '.version' || echo "none")
77

8-
if [[ -z "${previous_version}" || "${previous_version}" == "null" ]]; then
9-
previous_version="none"
10-
fi
11-
12-
if [[ "${previous_version}" == "${current_version}" ]]; then
13-
echo "false"
14-
else
15-
echo "true"
8+
if [[ "${previous_version}" == "${current_version}" ]]; then
9+
echo "false"
10+
else
11+
echo "true"
1612
fi

.github/workflows/ipa-changelog.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ jobs:
2121
2222
- name: Fetch Versions
2323
id: version_check
24-
env:
25-
BASE_BRANCH: ${{ github.event.pull_request.base.ref }}
2624
run: |
2725
version_changed=$(./.github/scripts/ipa_version_check.sh)
2826
echo "Version changed? ${version_changed}"

.github/workflows/ipa-release.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ jobs:
2424
.github/scripts
2525
- name: Fetch Versions
2626
id: version_check
27-
env:
28-
BASE_BRANCH: ${{ github.ref_name }}
2927
run: |
3028
version_changed=$(./.github/scripts/ipa_version_check.sh)
3129
echo "Version changed? ${version_changed}"

0 commit comments

Comments
 (0)