Skip to content

Commit 5afdba8

Browse files
fix
1 parent 3fc2a28 commit 5afdba8

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

tools/spectral/ipa/__tests__/metrics/data/expected-metric-results.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1755,7 +1755,7 @@
17551755
"severity_level": "warn",
17561756
"adoption_status": "violated",
17571757
"exception_reason": null,
1758-
"owner_team": "IAM",
1758+
"owner_team": null,
17591759
"timestamp": "2025-01-21T16:45:11.681Z"
17601760
}
17611761
]

tools/spectral/ipa/__tests__/metrics/metricCollection.test.js

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,22 @@ describe('tools/spectral/ipa/metrics/metricCollection.js runMetricCollectionJob'
2424

2525
it('Outputs the expected metrics collection results', async () => {
2626
const expectedResults = JSON.parse(fs.readFileSync(expectedResultFilePath, 'utf8'));
27-
console.log(expectedResults[expectedResults.length-1]);
2827
const spectral = new Spectral();
2928

3029
const results = await runMetricCollectionJob(testConfig, spectral);
3130

3231
expect(results).not.toBe(undefined);
3332
expect(results.metrics.length).toEqual(expectedResults.length);
3433

34+
expect(results.warnings.count).toEqual(1);
35+
const violations= [{
36+
code: 'xgen-IPA-104-valid-operation-id',
37+
message: 'IPA rule xgen-IPA-104-valid-operation-id violated',
38+
path: 'paths./api/atlas/v2/federationSettings/{federationSettingsId}/connectedOrgConfigs/{orgId}.get',
39+
source: null,
40+
}];
41+
expect(results.warnings.violations).toEqual(violations);
42+
3543
results.metrics.forEach((entry, index) => {
3644
const expectedEntry = getEntry(expectedResults, entry['component_id'], entry['ipa_rule']);
3745
expect(entry['component_id']).toEqual(expectedEntry['component_id']);

tools/spectral/ipa/metrics/metricCollection.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export async function runMetricCollectionJob(
2222
console.log('Extracting team ownership data...');
2323
const ownershipData = extractTeamOwnership(oasContent);
2424

25-
console.log(`Getting rule severities... ${rulesetFilePath}`);
25+
console.log('Getting rule severities...');
2626
const ruleset = await loadRuleset(rulesetFilePath, spectral);
2727
const ruleSeverityMap = getSeverityPerRule(ruleset);
2828

@@ -33,7 +33,7 @@ export async function runMetricCollectionJob(
3333
const mergedResults = merge(ownershipData, collectorResults, ruleSeverityMap);
3434

3535
const warningViolations = mergedResults.filter(result =>
36-
result.severity_level === 1 && result.adoption_status === 'violated'
36+
result.severity_level === 'warn' && result.adoption_status === 'violated'
3737
);
3838

3939
const processedWarnings = warningViolations.map(violation => ({

0 commit comments

Comments
 (0)