Skip to content

Commit 79da6ec

Browse files
author
Sophia Marie Terry
committed
CLOUDP-306294: Final get/list logic
1 parent c45f169 commit 79da6ec

File tree

2 files changed

+3
-17
lines changed

2 files changed

+3
-17
lines changed

tools/spectral/ipa/rulesets/functions/IPA104ValidOperationID.js

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,8 @@
11
import { generateOperationID } from './utils/operationIdGeneration.js';
22
import { collectAdoption, collectAndReturnViolation, collectException } from './utils/collectionUtils.js';
33
import { hasException } from './utils/exceptions.js';
4-
import {
5-
isSingleResourceIdentifier,
6-
isResourceCollectionIdentifier,
7-
isSingletonResource,
8-
getResourcePathItems,
9-
isCustomMethodIdentifier,
10-
} from './utils/resourceEvaluation.js';
11-
import { hasVerbOverride, isGetOverride, isLegacyCustomMethod, isListOverride } from './utils/extensions.js';
4+
import { getResourcePathItems, isCustomMethodIdentifier } from './utils/resourceEvaluation.js';
5+
import { isGetOverride, isLegacyCustomMethod, isListOverride } from './utils/extensions.js';
126
import { invalidGetMethod } from './utils/methodLogic.js';
137

148
const RULE_NAME = 'xgen-IPA-104-valid-operation-id';
@@ -35,9 +29,6 @@ export default (input, { methodName }, { path, documentInventory }) => {
3529

3630
const expectedOperationId = generateOperationID(methodName, resourcePath);
3731
if (expectedOperationId !== input.operationId) {
38-
if (isGetOverride(input)) {
39-
console.log( `${input.operationId}, ${expectedOperationId}, ${resourcePath}, ${input.deprecated ? 'TRUE' : 'FALSE'}, ${resourcePath, input['x-xgen-owner-team']}`);
40-
}
4132
const errors = [
4233
{
4334
path,

tools/spectral/ipa/rulesets/functions/IPA105ValidOperationID.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
import { hasException } from './utils/exceptions.js';
22
import { collectAdoption, collectAndReturnViolation, collectException } from './utils/collectionUtils.js';
3-
import {
4-
getResourcePathItems,
5-
isCustomMethodIdentifier,
6-
isResourceCollectionIdentifier,
7-
isSingletonResource,
8-
} from './utils/resourceEvaluation.js';
3+
import { getResourcePathItems, isCustomMethodIdentifier } from './utils/resourceEvaluation.js';
94
import { generateOperationID } from './utils/operationIdGeneration.js';
105
import { invalidListMethod } from './utils/methodLogic.js';
116
import { isLegacyCustomMethod, isGetOverride, isListOverride } from './utils/extensions.js';

0 commit comments

Comments
 (0)