CLOUDP-290416: Fix

Author: lovisaberggren

tools/spectral/ipa/metrics/metricS3Upload.js

@@ -10,17 +10,21 @@ import { getS3Client, getS3FilePath } from './utils/dataDumpUtils.js';
  * @param filePath file path to the metrics collection results, uses config.js by default
  */
 export async function uploadMetricCollectionDataToS3(filePath = config.defaultMetricCollectionResultsFilePath) {
+  console.log('Loading metrics collection data from', filePath);
+  const metricsCollectionData = JSON.parse(fs.readFileSync(filePath, 'utf8'));
+  if (metricsCollectionData === undefined || metricsCollectionData.length === 0) {
+    throw new Error('Loaded metrics collection data is empty');
+  }
+
   try {
     console.log('Creating S3 Client...');
     const client = getS3Client();
     const formattedDate = new Date().toISOString().split('T')[0];
 
-    console.log('Loading metrics collection data from', filePath);
-    const metricsCollectionData = JSON.parse(fs.readFileSync(filePath, 'utf8'));
-    const table = tableFromJSON(metricsCollectionData);
-
     console.log('Getting S3 file path...');
     const s3fileProps = getS3FilePath();
+
+    const table = tableFromJSON(metricsCollectionData);
     const command = new PutObjectCommand({
       Bucket: s3fileProps.bucketName,
       Key: path.join(s3fileProps.key, formattedDate, 'metric-collection-results.parquet'),
@@ -30,6 +34,7 @@ export async function uploadMetricCollectionDataToS3(filePath = config.defaultMe
     console.log('Dumping data to S3...');
     const response = await client.send(command);
     console.log(response);
+    return response;
   } catch (caught) {
     if (caught instanceof S3ServiceException && caught.name === 'EntityTooLarge') {
       console.error(

tools/spectral/ipa/metrics/scripts/dataDump.js

@@ -3,6 +3,14 @@ import { uploadMetricCollectionDataToS3 } from '../metricS3Upload.js';
 const args = process.argv.slice(2);
 const filePath = args[0];
 
-uploadMetricCollectionDataToS3(filePath)
-  .then(() => console.log('Data dump to S3 completed successfully.'))
-  .catch((error) => console.error(error.message));
+const response = await uploadMetricCollectionDataToS3(filePath).catch((error) => {
+  console.error(error.message);
+  process.exit(1);
+});
+
+if (!response) {
+  console.error('PutObject response is undefined');
+  process.exit(1);
+}
+
+console.log('Data dump to S3 completed successfully.');