fix(ipa): exception reason formatting

Author: yelizhenden-mdb

tools/spectral/ipa/__tests__/IPA005ExceptionExtensionFormat.test.js

@@ -8,13 +8,13 @@ testRule('xgen-IPA-005-exception-extension-format', [
       paths: {
         '/path': {
           'x-xgen-IPA-exception': {
-            'xgen-IPA-100-rule-name': 'Exception',
+            'xgen-IPA-100-rule-name': 'Exception.',
           },
         },
         '/nested': {
           post: {
             'x-xgen-IPA-exception': {
-              'xgen-IPA-100-rule-name': 'Exception',
+              'xgen-IPA-100-rule-name': 'Exception.',
             },
           },
         },
@@ -51,26 +51,26 @@ testRule('xgen-IPA-005-exception-extension-format', [
     errors: [
       {
         code: 'xgen-IPA-005-exception-extension-format',
-        message: 'IPA exceptions must have a valid rule name and a reason.',
+        message: 'IPA exceptions must have a valid key with xgen-IPA- prefix.',
         path: ['paths', '/path1', 'x-xgen-IPA-exception'],
         severity: DiagnosticSeverity.Error,
       },
       {
         code: 'xgen-IPA-005-exception-extension-format',
-        message: 'IPA exceptions must have a valid rule name and a reason.',
-        path: ['paths', '/path2', 'x-xgen-IPA-exception', 'xgen-IPA-100-rule-name'],
+        message: 'IPA exceptions must have a non-empty reason that starts with uppercase and ends with a full stop.',
+        path: ['paths', '/path2', 'x-xgen-IPA-exception'],
         severity: DiagnosticSeverity.Error,
       },
       {
         code: 'xgen-IPA-005-exception-extension-format',
-        message: 'IPA exceptions must have a valid rule name and a reason.',
-        path: ['paths', '/path3', 'x-xgen-IPA-exception', 'invalid-rule-name'],
+        message: 'IPA exceptions must have a valid key with xgen-IPA- prefix.',
+        path: ['paths', '/path3', 'x-xgen-IPA-exception'],
         severity: DiagnosticSeverity.Error,
       },
       {
         code: 'xgen-IPA-005-exception-extension-format',
-        message: 'IPA exceptions must have a valid rule name and a reason.',
-        path: ['paths', '/path4', 'x-xgen-IPA-exception', 'xgen-IPA-100-rule-name'],
+        message: 'IPA exceptions must have a non-empty reason that starts with uppercase and ends with a full stop.',
+        path: ['paths', '/path4', 'x-xgen-IPA-exception'],
         severity: DiagnosticSeverity.Error,
       },
     ],

tools/spectral/ipa/rulesets/IPA-005.yaml

@@ -12,7 +12,7 @@ rules:
       ##### Implementation details
       Rule checks for the following conditions:
         - Exception rule names must start with 'xgen-IPA-' prefix
-        - Each exception must include a non-empty reason as a string
+        - Each exception must include a non-empty reason as a string that starts with uppercase and ends with a full stop
         - This rule itself does not allow exceptions
     message: '{{error}} https://mdb.link/mongodb-atlas-openapi-validation#xgen-IPA-005-exception-extension-format'
     severity: error

tools/spectral/ipa/rulesets/functions/IPA005ExceptionExtensionFormat.js

@@ -1,6 +1,10 @@
-import { evaluateAndCollectAdoptionStatusWithoutExceptions, handleInternalError } from './utils/collectionUtils.js';
+import {
+  evaluateAndCollectAdoptionStatusWithoutExceptions,
+  handleInternalError,
+} from './utils/collectionUtils.js';
 
-const ERROR_MESSAGE = 'IPA exceptions must have a valid rule name and a reason.';
+const ERROR_MESSAGE_RULENAME_FORMAT = 'IPA exceptions must have a valid key with xgen-IPA- prefix.';
+const ERROR_MESSAGE_REASON_FORMAT = 'IPA exceptions must have a non-empty reason that starts with uppercase and ends with a full stop.';
 const RULE_NAME_PREFIX = 'xgen-IPA-';
 
 // Note: This rule does not allow exceptions
@@ -10,21 +14,44 @@ export default (input, _, { path, rule }) => {
   return evaluateAndCollectAdoptionStatusWithoutExceptions(errors, ruleName, path);
 };
 
-function isValidException(ruleName, reason) {
-  return ruleName.startsWith(RULE_NAME_PREFIX) && typeof reason === 'string' && reason !== '';
+function isRuleNameValid(ruleName) {
+  return ruleName.startsWith(RULE_NAME_PREFIX);
+}
+
+function isReasonFormatValid(reason) {
+  if (reason === null || reason === undefined || typeof reason !== 'string' || reason === '') {
+    return false;
+  }
+  // Check if reason starts with uppercase letter
+  if (!/^[A-Z]/.test(reason)) {
+    return false;
+  }
+
+  // Check if reason ends with a full stop
+  if (!reason.endsWith('.')) {
+    return false;
+  }
+  return true;
 }
 
 function checkViolationsAndReturnErrors(input, path, ruleName) {
   const errors = [];
   try {
     const exemptedRules = Object.keys(input);
-    exemptedRules.forEach((ruleName) => {
-      const reason = input[ruleName];
-      if (!isValidException(ruleName, reason)) {
+    exemptedRules.forEach((key) => {
+      const reason = input[key];
+      if (!isRuleNameValid(key)) {
         errors.push({
           path: path.concat([ruleName]),
-          message: ERROR_MESSAGE,
+          message: ERROR_MESSAGE_RULENAME_FORMAT,
         });
+      } else {
+        if (!isReasonFormatValid(reason)) {
+          errors.push({
+            path: path.concat([ruleName]),
+            message: ERROR_MESSAGE_REASON_FORMAT,
+          });
+        }
       }
     });
     return errors;