address the comments

Author: yelizhenden-mdb

eslint.config.mjs

@@ -25,6 +25,12 @@ export default [
       ecmaVersion: 2022,
       sourceType: 'module',
     },
+    rules: {
+      'no-extra-boolean-cast': ['warn',
+        {
+          enforceForLogicalOperands: true,
+        }]
+    },
   },
   {
     ignores: ['node-modules'],

tools/spectral/ipa/rulesets/functions/IPA110CollectionsRequestIncludeCountNotRequired.js

@@ -25,18 +25,12 @@ export default (input, _, { path, documentInventory }) => {
     return;
   }
 
-  const parameters = input.parameters;
-  if (!parameters) {
-    return;
-  }
-
-  const includeCountParam = parameters.find((p) => p.name === 'includeCount' && p.in === 'query');
-
+  const includeCountParam = input?.parameters?.find((p) => p.name === 'includeCount' && p.in === 'query');
   if (!includeCountParam) {
     return;
   }
 
-  if (includeCountParam.required === true) {
+  if (includeCountParam.required) {
     return collectAndReturnViolation(path, RULE_NAME, ERROR_MESSAGE);
   }
 

tools/spectral/ipa/rulesets/functions/IPA110CollectionsResponseDefineLinksArray.js

@@ -50,10 +50,7 @@ export default (input, _, { path, documentInventory }) => {
 
 function checkViolationsAndReturnErrors(listResponseSchema, oas, path) {
   try {
-    const hasLinksArray =
-      listResponseSchema.properties &&
-      listResponseSchema.properties.links &&
-      listResponseSchema.properties.links.type === 'array';
+    const hasLinksArray = listResponseSchema.properties?.links?.type === 'array';
 
     if (!hasLinksArray) {
       return [

tools/spectral/ipa/rulesets/functions/utils/schemaUtils.js

@@ -4,7 +4,7 @@
  * @returns true if schema object returns results property (pagination), false otherwise
  */
 export function schemaIsPaginated(schema) {
-  const hasResultsArray = schema.properties && schema.properties.results && schema.properties.results.type === 'array';
+  const hasResultsArray = schema.properties?.results?.type === 'array';
 
   return hasResultsArray;
 }