error message fix

Author: yelizhenden-mdb

tools/spectral/ipa/__tests__/createMethodRequestBodyIsRequestSuffixedObject.test.js

@@ -129,25 +129,25 @@ testRule('xgen-IPA-106-create-method-request-body-is-request-suffixed-object', [
     errors: [
       {
         code: 'xgen-IPA-106-create-method-request-body-is-request-suffixed-object',
-        message: 'Response body for the Create method should refer to Request suffixed schema. http://go/ipa/106',
+        message: 'The response body schema must reference a schema with a Request suffix. http://go/ipa/106',
         path: ['paths', '/resource', 'post', 'requestBody', 'content', 'application/vnd.atlas.2023-01-01+json'],
         severity: DiagnosticSeverity.Warning,
       },
       {
         code: 'xgen-IPA-106-create-method-request-body-is-request-suffixed-object',
-        message: 'Response body for the Create method should refer to Request suffixed schema. http://go/ipa/106',
+        message: 'The response body schema must reference a schema with a Request suffix. http://go/ipa/106',
         path: ['paths', '/resource2', 'post', 'requestBody', 'content', 'application/vnd.atlas.2023-01-01+json'],
         severity: DiagnosticSeverity.Warning,
       },
       {
         code: 'xgen-IPA-106-create-method-request-body-is-request-suffixed-object',
-        message: 'Response body for the Create method should refer to Request suffixed schema. http://go/ipa/106',
+        message: 'The response body schema must reference a schema with a Request suffix. http://go/ipa/106',
         path: ['paths', '/resource2', 'post', 'requestBody', 'content', 'application/vnd.atlas.2024-01-01+json'],
         severity: DiagnosticSeverity.Warning,
       },
       {
         code: 'xgen-IPA-106-create-method-request-body-is-request-suffixed-object',
-        message: 'Response body for the Create method should refer to Request suffixed schema. http://go/ipa/106',
+        message: 'The response body schema is defined inline and must reference a predefined schema. http://go/ipa/106',
         path: ['paths', '/resource3', 'post', 'requestBody', 'content', 'application/vnd.atlas.2023-01-01+json'],
         severity: DiagnosticSeverity.Warning,
       },

tools/spectral/ipa/rulesets/functions/createMethodRequestBodyIsRequestSuffixedObject.js

@@ -4,7 +4,8 @@ import { isCustomMethod } from './utils/resourceEvaluation.js';
 import { resolveObject } from './utils/componentUtils.js';
 
 const RULE_NAME = 'xgen-IPA-106-create-method-request-body-is-request-suffixed-object';
-const ERROR_MESSAGE = 'Response body for the Create method should refer to Request suffixed schema.';
+const ERROR_MESSAGE_SCHEMA_NAME = 'The response body schema must reference a schema with a Request suffix.';
+const ERROR_MESSAGE_SCHEMA_REF = 'The response body schema is defined inline and must reference a predefined schema.';
 
 export default (input, _, { path, documentInventory }) => {
   const oas = documentInventory.unresolved;
@@ -24,11 +25,11 @@ export default (input, _, { path, documentInventory }) => {
   if (contentPerMediaType.schema) {
     const schema = contentPerMediaType.schema;
     if(!schema.$ref) {
-      return collectAndReturnViolation(path, RULE_NAME, ERROR_MESSAGE);
+      return collectAndReturnViolation(path, RULE_NAME, ERROR_MESSAGE_SCHEMA_REF);
     }
 
     if (!schema.$ref.endsWith('Request')) {
-      return collectAndReturnViolation(path, RULE_NAME, ERROR_MESSAGE);
+      return collectAndReturnViolation(path, RULE_NAME, ERROR_MESSAGE_SCHEMA_NAME);
     }
   }