CLOUDP-271997- IPA 108 Delete 404 status code is returned when trying to delete a non-existing IPA

Author: wtrocki

tools/spectral/ipa/__tests__/deleteMethod404Response.test.js

@@ -0,0 +1,63 @@
+import testRule from './__helpers__/testRule';
+import { DiagnosticSeverity } from '@stoplight/types';
+
+testRule('xgen-IPA-108-delete-include-404-response', [
+  {
+    name: 'valid DELETE with 404',
+    document: {
+      paths: {
+        '/resource/{id}': {
+          delete: {
+            responses: {
+              204: {},
+              404: {
+                description: 'Resource not found',
+              },
+            },
+          },
+        },
+      },
+    },
+    errors: [],
+  },
+  {
+    name: 'invalid DELETE missing 404',
+    document: {
+      paths: {
+        '/resource/{id}': {
+          delete: {
+            responses: {
+              204: {},
+            },
+          },
+        },
+      },
+    },
+    errors: [
+      {
+        code: 'xgen-IPA-108-delete-include-404-response',
+        message: 'DELETE method should include 404 status code for not found resources http://go/ipa/108',
+        path: ['paths', '/resource/{id}', 'delete'],
+        severity: DiagnosticSeverity.Warning,
+      },
+    ],
+  },
+  {
+    name: 'valid with exception',
+    document: {
+      paths: {
+        '/resource/{id}': {
+          delete: {
+            'x-xgen-IPA-exception': {
+              'xgen-IPA-108-delete-include-404-response': 'Idempotent delete',
+            },
+            responses: {
+              204: {},
+            },
+          },
+        },
+      },
+    },
+    errors: [],
+  },
+]);

tools/spectral/ipa/rulesets/IPA-108.yaml

@@ -18,6 +18,24 @@ rules:
     then:
       function: deleteMethod204Response
 
+  xgen-IPA-108-delete-include-404-response:
+    description: DELETE method must include 404 response and return it when resource not found
+    message: '{{error}} http://go/ipa/108'
+    severity: warn
+    given: $.paths[*].delete
+    then:
+      function: deleteMethod404Response
+
+  xgen-IPA-108-delete-request-no-body:
+    description: DELETE method must not have request body
+    message: '{{error}} http://go/ipa/108'
+    severity: warn
+    given: $.paths[*].delete
+    then:
+      function: deleteMethodNoRequestBody
+
 functions:
   - deleteMethodResponseShouldNotHaveSchema
   - deleteMethod204Response
+  - deleteMethodNoRequestBody
+  - deleteMethod404Response

tools/spectral/ipa/rulesets/functions/deleteMethod404Response.js

@@ -0,0 +1,29 @@
+import { collectAdoption, collectAndReturnViolation, collectException } from './utils/collectionUtils.js';
+import { hasException } from './utils/exceptions.js';
+
+const RULE_NAME = 'xgen-IPA-108-delete-include-404-response';
+const ERROR_MESSAGE = 'DELETE method should include 404 status code for not found resources';
+
+/**
+ * Delete method should include 404 status code for not found resources
+ *
+ * @param {object} input - The delete operation object
+ * @param {object} _ - Unused
+ * @param {object} context - The context object containing the path
+ */
+export default (input, _, { path }) => {
+  const deleteOp = input;
+  if (!deleteOp) return;
+
+  if (hasException(deleteOp, RULE_NAME)) {
+    collectException(deleteOp, RULE_NAME, path);
+    return;
+  }
+
+  const responses = deleteOp.responses || {};
+  if (!responses['404']) {
+    return collectAndReturnViolation(path, RULE_NAME, ERROR_MESSAGE);
+  }
+
+  collectAdoption(path, RULE_NAME);
+};