CLOUDP-290416: Refactor and clean up

Author: lovisaberggren

.github/workflows/release-IPA-metrics.yml

@@ -43,7 +43,10 @@ jobs:
           github-token: ${{ secrets.api_bot_pat }}
           script: |
             const { default: getShouldRunMetricsRelease } = await import('${{ github.workspace }}/tools/spectral/ipa/metrics/scripts/getShouldRunMetricsRelease.js')
-            const shouldRunRelease = await getShouldRunMetricsRelease({github, context})
+            const shouldRunRelease = await getShouldRunMetricsRelease({github, context}).catch((error) => {
+              console.error(error.message);
+              process.exit(1)
+            })
             return shouldRunRelease
 
   release-IPA-metrics:

tools/spectral/ipa/metrics/metricS3Upload.js

@@ -24,10 +24,10 @@ export async function uploadMetricCollectionDataToS3(filePath = config.defaultMe
   try {
     console.log('Creating S3 Client...');
     const client = getS3Client();
-    const formattedDate = new Date().toISOString().split('T')[0];
 
     console.log('Getting S3 file path...');
     const s3fileProps = getS3FilePath();
+    const formattedDate = new Date().toISOString().split('T')[0];
 
     const command = new PutObjectCommand({
       Bucket: s3fileProps.bucketName,

tools/spectral/ipa/metrics/scripts/getShouldRunMetricsRelease.js

@@ -8,20 +8,16 @@ export default async function getShouldRunMetricsRelease({ github, context }) {
     page: 1,
   });
 
-  if (response === undefined || response.data === undefined) {
-    return true;
+  if (!response || !response.data) {
+    throw Error('listWorkFlowRuns response is empty');
   }
 
   const { workflow_runs: runs } = response.data;
 
-  console.log('Runs:', runs);
-
   if (runs === undefined || runs.length === 0) {
-    return true;
+    throw Error('response.data.workflow_runs is empty');
   }
 
-  console.log('Last run:', runs[1]);
-
   const previousResult = runs[1].conclusion;
 
   const lastRunDate = new Date(runs[1].created_at);