fix: minor refinement

Author: lovisaberggren

tools/spectral/ipa/rulesets/functions/utils/collectionUtils.js

@@ -6,10 +6,10 @@ import { EXCEPTION_EXTENSION, hasException } from './exceptions.js';
  * If the object is violating the rule, but has an exception, the validation error is ignored
  * If the object is adopting the rule, but has an exception, a validation error will be returned
  *
- * @param validationErrors the error results from the rule
- * @param ruleName the name of the rule
- * @param object the object evaluated for the rule, should contain an exception object if an exception is needed
- * @param objectPath the JSON path to the object
+ * @param {Array<{path: Array<string>, message: string}>} validationErrors the error results from the rule
+ * @param {string} ruleName the name of the rule
+ * @param {*} object the object evaluated for the rule, should contain an exception object if an exception is needed
+ * @param {Array<string>} objectPath the JSON path to the object
  * @returns {Array<{path: Array<string>, message: string}>|undefined} an array of the validation errors, or undefined if there are no errors
  */
 export function collectExceptionAdoptionViolations(validationErrors, ruleName, object, objectPath) {
@@ -21,12 +21,12 @@ export function collectExceptionAdoptionViolations(validationErrors, ruleName, o
     return collectAndReturnViolation(objectPath, ruleName, validationErrors);
   }
   if (hasException(object, ruleName)) {
-    const error = {
-      path: [...objectPath, EXCEPTION_EXTENSION, ruleName],
-      message: 'This component adopts the rule and does not need an exception. Please remove the exception.',
-    };
-    validationErrors.push(error);
-    return collectAndReturnViolation(objectPath, ruleName, [error]);
+    return collectAndReturnViolation(objectPath, ruleName, [
+      {
+        path: [...objectPath, EXCEPTION_EXTENSION, ruleName],
+        message: 'This component adopts the rule and does not need an exception. Please remove the exception.',
+      },
+    ]);
   }
   collectAdoption(objectPath, ruleName);
 }
@@ -35,9 +35,9 @@ export function collectExceptionAdoptionViolations(validationErrors, ruleName, o
  * Evaluates and collects adoptions and violations based on the rule, evaluated object and the validation errors.
  * No exceptions are allowed.
  *
- * @param validationErrors the error results from the rule
- * @param ruleName the name of the rule
- * @param objectPath the JSON path to the object
+ * @param {Array<{path: Array<string>, message: string}>} validationErrors the error results from the rule
+ * @param {string} ruleName the name of the rule
+ * @param {Array<string>} objectPath the JSON path to the object
  * @returns {Array<{path: Array<string>, message: string}>|undefined} an array of the validation errors, or undefined if there are no errors
  */
 export function collectAdoptionViolations(validationErrors, ruleName, objectPath) {