Skip to content

Commit fb2bf6e

Browse files
committed
Fix tests
1 parent 9cc82a7 commit fb2bf6e

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

tools/cli/internal/cli/split/split.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ func Builder() *cobra.Command {
136136
}
137137

138138
cmd.Flags().StringVarP(&opts.basePath, flag.Spec, flag.SpecShort, "-", usage.Spec)
139-
cmd.Flags().StringVar(&opts.env, flag.Environment, "", usage.Environment)
139+
cmd.Flags().StringVar(&opts.env, flag.Environment, "prod", usage.Environment)
140140
cmd.Flags().StringVarP(&opts.outputPath, flag.Output, flag.OutputShort, "", usage.Output)
141141
cmd.Flags().StringVarP(&opts.format, flag.Format, flag.FormatShort, openapi.ALL, usage.Format)
142142
cmd.Flags().StringVar(&opts.gitSha, flag.GitSha, "", usage.GitSha)

tools/cli/internal/cli/split/split_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ func TestSuccessfulSplit_Run(t *testing.T) {
3131
basePath: "../../../test/data/base_spec.json",
3232
outputPath: "foas.yaml",
3333
fs: fs,
34+
env: "dev",
3435
}
3536

3637
if err := opts.Run(); err != nil {
@@ -44,6 +45,7 @@ func TestSplitPublicPreviewRun(t *testing.T) {
4445
basePath: "../../../test/data/base_spec_with_public_preview.json",
4546
outputPath: "foas.yaml",
4647
fs: fs,
48+
env: "dev",
4749
}
4850

4951
if err := opts.Run(); err != nil {
@@ -64,6 +66,7 @@ func TestSplitPrivatePreviewRun(t *testing.T) {
6466
basePath: "../../../test/data/base_spec_with_private_preview.json",
6567
outputPath: "foas.yaml",
6668
fs: fs,
69+
env: "dev",
6770
}
6871

6972
if err := opts.Run(); err != nil {
@@ -83,6 +86,7 @@ func TestSplitMulitplePreviewsRun(t *testing.T) {
8386
opts := &Opts{
8487
basePath: "../../../test/data/base_spec_with_multiple_private_and_public_previews.json",
8588
outputPath: "foas.yaml",
89+
env: "dev",
8690
fs: fs,
8791
}
8892

@@ -122,6 +126,7 @@ func TestInjectSha_Run(t *testing.T) {
122126
outputPath: "foas.yaml",
123127
fs: fs,
124128
gitSha: "123456",
129+
env: "dev",
125130
}
126131

127132
if err := opts.Run(); err != nil {

tools/cli/internal/openapi/filter/filter_test.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,9 @@ func TestNewMetadata(t *testing.T) {
3333

3434
func TestValidateMetadata(t *testing.T) {
3535
t.Run("Valid metadata", func(t *testing.T) {
36-
metadata := &Metadata{}
36+
metadata := &Metadata{
37+
targetEnv: "dev",
38+
}
3739
err := validateMetadata(metadata)
3840
assert.NoError(t, err)
3941
})

0 commit comments

Comments
 (0)