Skip to content

Commit fbaac28

Browse files
CLOUDP-284672: [API Platform] Changelog did not detect new flexClusters endpoints automatically
1 parent df06dcc commit fbaac28

File tree

2 files changed

+61
-1
lines changed

2 files changed

+61
-1
lines changed

.github/workflows/release-spec.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,6 @@ jobs:
167167
release-changelog:
168168
name: Release API Changelog
169169
needs: release
170-
if: ${{ needs.release.outputs.changes_detected == 'true' }}
171170
uses: ./.github/workflows/release-changelog.yml
172171
secrets:
173172
api_bot_pat: ${{ secrets.api_bot_pat }}

tools/cli/internal/changelog/changelog_test.go

Lines changed: 61 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -861,3 +861,64 @@ func TestFindChangelogEntry(t *testing.T) {
861861
})
862862
}
863863
}
864+
865+
func TestLatestVersionActiveOnDate(t *testing.T) {
866+
tests := []struct {
867+
name string
868+
date string
869+
versions []string
870+
expectedOutput string
871+
expectedError assert.ErrorAssertionFunc
872+
}{
873+
{
874+
name: "Valid case with multiple versions",
875+
date: "2024-11-13",
876+
versions: []string{"2023-01-01",
877+
"2023-02-01",
878+
"2023-10-01",
879+
"2023-11-15",
880+
"2024-05-30",
881+
"2024-08-05",
882+
"2024-10-23",
883+
"2024-11-13"},
884+
expectedOutput: "2024-11-13",
885+
expectedError: assert.NoError,
886+
},
887+
//{
888+
// name: "Date before all versions",
889+
// date: "2022-12-11",
890+
// versions: []string{"2023-01-01", "2023-06-01", "2023-11-01"},
891+
// expectedOutput: "",
892+
// expectedError: assert.NoError,
893+
//},
894+
//{
895+
// name: "Empty versions list",
896+
// date: "2023-12-11",
897+
// versions: []string{},
898+
// expectedOutput: "",
899+
// expectedError: assert.NoError,
900+
//},
901+
//{
902+
// name: "Invalid date format",
903+
// date: "invalid-date",
904+
// versions: []string{"2023-01-01"},
905+
// expectedOutput: "",
906+
// expectedError: assert.Error,
907+
//},
908+
//{
909+
// name: "Invalid version format in list",
910+
// date: "2023-12-11",
911+
// versions: []string{"invalid-version", "2023-06-01"},
912+
// expectedOutput: "",
913+
// expectedError: assert.Error,
914+
//},
915+
}
916+
917+
for _, tt := range tests {
918+
t.Run(tt.name, func(t *testing.T) {
919+
output, err := latestVersionActiveOnDate(tt.date, tt.versions)
920+
tt.expectedError(t, err)
921+
assert.Equal(t, output, tt.expectedOutput)
922+
})
923+
}
924+
}

0 commit comments

Comments
 (0)