CLOUDP-287250: Add rule IPA-113 Singleton must not have ID #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovisaberggren
commented
Jan 8, 2025
| "@babel/preset-env": "^7.26.0", | ||
| "@eslint/js": "^9.16.0", | ||
| "@jest/globals": "^29.7.0", | ||
| "@stoplight/types": "^14.1.1", |
Collaborator
Author
There was a problem hiding this comment.
Added as I noticed this one wasn't in the package.json, though we use it in the test files
lovisaberggren
commented
Jan 8, 2025
Comment on lines
+28
to
+46
| async function createSpectral(ruleName) { | ||
| const rulesetPath = path.join(__dirname, '../../rulesets', ruleName.slice(5, 12) + '.yaml'); | ||
| const s = new Spectral({ resolver: httpAndFileResolver }); | ||
| s.setRuleset(await bundleAndLoadRuleset(rulesetPath, { fs, fetch })); | ||
| const ruleset = Object(await bundleAndLoadRuleset(rulesetPath, { fs, fetch })).toJSON(); | ||
| s.setRuleset(getRulesetForRule(ruleName, ruleset)); | ||
| return s; | ||
| } | ||
|
|
||
| function getErrorsForRule(errors, rule) { | ||
| return errors.filter((e) => e.code === rule); | ||
| /** | ||
| * Takes the passed ruleset and returns a ruleset with only the specified rule. | ||
| * | ||
| * @param ruleName the name of the rule | ||
| * @param ruleset the ruleset containing the rule by ruleName and optionally other rules | ||
| * @returns {Object} a ruleset with only the rule with name ruleName | ||
| */ | ||
| function getRulesetForRule(ruleName, ruleset) { | ||
| const modifiedRuleset = { rules: {} }; | ||
| modifiedRuleset.rules[ruleName] = ruleset.rules[ruleName].definition; | ||
| return modifiedRuleset; |
Collaborator
Author
There was a problem hiding this comment.
Drive-by to create a spectral instance with only the specific rule for the test run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds rule for IPA 113: "Singleton resources must not have a user-provided or system-generated ID".
idor_idit returns a validation errorDrive-by:
Current offenders:
Jira ticket: CLOUDP-287250