Skip to content

Conversation

@wtrocki
Copy link
Member

@wtrocki wtrocki commented Mar 18, 2025

Proposed changes

Refined DELETE operations validation rules (IPA-108) to only apply to single resource endpoints with path parameters. This ensures proper REST semantics where DELETE should operate on specific resources rather than collections.

Changes include:

  • Updated documentation to clarify rule application scope
  • Added test cases to verify correct behavior for both resource and collection endpoints
  • Added path parameter detection using the isSingleResourceIdentifier helper

Reused helper function created by @yelizhenden-mdb. Thank you for refinement and implementation!

@wtrocki wtrocki requested a review from a team as a code owner March 18, 2025 13:41
@wtrocki wtrocki requested a review from yelizhenden-mdb March 18, 2025 14:33
Copy link
Collaborator

@yelizhenden-mdb yelizhenden-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@wtrocki wtrocki merged commit b981826 into main Mar 18, 2025
8 checks passed
@wtrocki wtrocki deleted the CLOUDP-306347 branch March 18, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants