Skip to content

CLOUDP-309109: Third rollout for IPA validations #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2025
Merged

CLOUDP-309109: Third rollout for IPA validations #625

merged 2 commits into from
Mar 27, 2025

Conversation

@yelizhenden-mdb
Copy link
Collaborator

@yelizhenden-mdb yelizhenden-mdb commented Mar 27, 2025 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-309109

Changes severity level from warn to error for the following IPA rules:

xgen-IPA-102-collection-identifier-camelCase
xgen-IPA-102-collection-identifier-pattern
xgen-IPA-106-create-method-request-body-is-get-method-response
xgen-IPA-106-create-method-response-is-get-method-response
xgen-IPA-107-update-method-request-body-is-get-method-response
xgen-IPA-107-update-method-request-body-is-update-request-suffixed-object
xgen-IPA-107-update-method-request-has-no-readonly-fields
xgen-IPA-107-update-method-response-is-get-method-response
xgen-IPA-107-update-must-not-have-query-params
xgen-IPA-107-update-method-response-code-is-200
xgen-IPA-108-delete-response-should-be-empty
xgen-IPA-108-delete-method-return-204-response
xgen-IPA-108-delete-request-no-body
xgen-IPA-108-delete-include-404-response
xgen-IPA-113-singleton-must-not-have-id
xgen-IPA-113-singleton-must-not-have-delete-method
xgen-IPA-113-singleton-should-have-update-method

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works

Changes to Spectral

  • I have read the README file for Spectral Updates

Further comments

@yelizhenden-mdb yelizhenden-mdb marked this pull request as ready for review March 27, 2025 12:45
@yelizhenden-mdb yelizhenden-mdb requested a review from a team as a code owner March 27, 2025 12:45
@yelizhenden-mdb
Copy link
Collaborator Author

FYI: CI checks failing for the xgen-IPA-113-singleton-should-have-update-method rule for a component. I will add an exception for the component on the MMS side when I update the IPA Spectral ruleset reference

wtrocki
wtrocki approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@wtrocki wtrocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting

@yelizhenden-mdb yelizhenden-mdb merged commit 91e0b7c into main Mar 27, 2025
6 of 8 checks passed
@yelizhenden-mdb yelizhenden-mdb deleted the CLOUDP-309109 branch March 27, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wtrocki wtrocki wtrocki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yelizhenden-mdb @wtrocki