CLOUDP-306576: IPA-119: Multi-Cloud Support (Fix)

[yelizhenden-mdb]

Proposed changes

Jira ticket: CLOUDP-306576

If a field or parameter isn't related to a cloud provider, don’t mark the component as adopting the rule

Checklist

• I have signed the MongoDB CLA
• I have added tests that prove my fix is effective or that my feature works

Changes to Spectral

• I have read the README file for Spectral Updates

Further comments

[Copilot]

Pull Request Overview

This pull request refactors the IPA-119 rule function to improve its handling of default values for cloud provider-related fields and updates unit tests for consistency.

• Refactored error checking by returning a result object with error information and a flag indicating a cloud provider field.
• Removed redundant parameter checks and updated unit test names for consistency.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
tools/spectral/ipa/rulesets/functions/IPA119NoDefaultForCloudProviders.js	Refactored default value checks and error handling for properties and parameters
tools/spectral/ipa/tests/IPA119NoDefaultForCloudProviders.test.js	Updated test names for consistency in cloud provider field naming

Comments suppressed due to low confidence (2)

tools/spectral/ipa/rulesets/functions/IPA119NoDefaultForCloudProviders.js:81

• Potential runtime error: 'propertyObject.schema' is accessed without verifying its existence. Consider adding a check to ensure 'propertyObject.schema' is defined before accessing its 'default' property.

if (propertyObject.name === propertyNameToLookFor) {

tools/spectral/ipa/tests/IPA119NoDefaultForCloudProviders.test.js:50

• [nitpick] Test case name is inconsistent with the other case using 'cloudProvider'. Consider renaming it to 'invalid when cloudProvider field has default value' for clarity and uniformity.

name: 'invalid when provider field has default value',