DOP-1073: no longer render RefRole prefix if no title is found

Author: i80and

CHANGELOG.md

@@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Populate literal include nodes (DOP-876).
 
+### Fixed
+
+- RefRole nodes no longer render with the prefix if no title is found (DOP-1073).
+
 ## [v0.4.9] - 2020-06-05
 
 ### Added

snooty/cache.py

@@ -0,0 +1,42 @@
+from collections import defaultdict
+from dataclasses import dataclass, field
+from typing import Set, Tuple, Dict, DefaultDict, Optional, Iterator, TypeVar, Generic
+
+_T = TypeVar("_T")
+
+
+@dataclass
+class Cache(Generic[_T]):
+    """A versioned cache that associates a (_T, int) pair with an arbitrary object and
+       an integer version. Whenever the key is re-assigned, the version is incremented."""
+
+    _cache: Dict[Tuple[_T, int], object] = field(default_factory=dict)
+    _keys_of_each_fileid: DefaultDict[_T, Set[int]] = field(
+        default_factory=lambda: defaultdict(set)
+    )
+    _versions: DefaultDict[Tuple[_T, int], int] = field(
+        default_factory=lambda: defaultdict(int)
+    )
+
+    def __setitem__(self, key: Tuple[_T, int], value: object) -> None:
+        if key in self._cache:
+            self._cache[key] = value
+        else:
+            self._cache[key] = value
+
+        self._versions[key] += 1
+        self._keys_of_each_fileid[key[0]].add(key[1])
+
+    def __delitem__(self, fileid: _T) -> None:
+        keys = self._keys_of_each_fileid[fileid]
+        del self._keys_of_each_fileid[fileid]
+        for key in keys:
+            del self._cache[(fileid, key)]
+
+    def __getitem__(self, key: Tuple[_T, int]) -> Optional[object]:
+        return self._cache.get(key, None)
+
+    def get_versions(self, fileid: _T) -> Iterator[int]:
+        for key, version in self._versions.items():
+            if key[0] == fileid:
+                yield version

snooty/eventparser.py

@@ -1,5 +1,6 @@
 from typing import Any, Callable, Dict, Set, Tuple, Iterable, Union
-from .types import FileId, Page
+from .types import FileId
+from .page import Page
 from . import n
 
 

snooty/gizaparser/extracts.py

@@ -4,7 +4,8 @@
 from ..flutter import checked
 from .nodes import Inheritable, GizaCategory, HeadingMixin
 from .parse import parse
-from ..types import EmbeddedRstParser, Page
+from ..types import EmbeddedRstParser
+from ..page import Page
 from ..diagnostics import Diagnostic, MissingRef
 from .. import n
 

snooty/gizaparser/nodes.py

@@ -24,14 +24,15 @@
     Set,
 )
 from ..flutter import checked
-from ..types import Page, EmbeddedRstParser, ProjectConfig
+from ..types import EmbeddedRstParser, ProjectConfig
 from ..diagnostics import (
     Diagnostic,
     UnknownSubstitution,
     FailedToInheritRef,
     CannotOpenFile,
     RefAlreadyExists,
 )
+from ..page import Page
 from .. import n
 
 _T = TypeVar("_T", str, object)

snooty/gizaparser/release.py

@@ -2,7 +2,8 @@
 from pathlib import Path
 from typing import Callable, Optional, List, Tuple, Sequence
 from ..flutter import checked
-from ..types import EmbeddedRstParser, Page
+from ..types import EmbeddedRstParser
+from ..page import Page
 from ..diagnostics import Diagnostic, MissingRef
 from .. import n
 from .parse import parse

snooty/gizaparser/steps.py

@@ -5,7 +5,8 @@
 from .. import n
 from .parse import parse
 from .nodes import Inheritable, GizaCategory, HeadingMixin
-from ..types import EmbeddedRstParser, Page
+from ..types import EmbeddedRstParser
+from ..page import Page
 from ..diagnostics import Diagnostic
 
 

snooty/gizaparser/test_extracts.py

@@ -1,7 +1,8 @@
 from pathlib import Path, PurePath
 from typing import Dict, Tuple, List, Optional
 from .extracts import GizaExtractsCategory
-from ..types import Page, ProjectConfig
+from ..types import ProjectConfig
+from ..page import Page
 from ..diagnostics import Diagnostic
 from ..parser import EmbeddedRstParser
 from ..util_test import ast_to_testing_string

snooty/gizaparser/test_release.py

@@ -1,7 +1,8 @@
 from pathlib import Path, PurePath
 from typing import Dict, Tuple, List, Optional
 from .release import GizaReleaseSpecificationCategory
-from ..types import Page, ProjectConfig
+from ..types import ProjectConfig
+from ..page import Page
 from ..diagnostics import Diagnostic
 from ..parser import EmbeddedRstParser
 from ..util_test import check_ast_testing_string

snooty/gizaparser/test_steps.py

@@ -1,7 +1,8 @@
 from pathlib import Path, PurePath
 from typing import Dict, Tuple, List, Optional
 from .steps import GizaStepsCategory
-from ..types import Page, ProjectConfig
+from ..types import ProjectConfig
+from ..page import Page
 from ..diagnostics import Diagnostic
 from ..parser import EmbeddedRstParser
 from ..util_test import ast_to_testing_string, check_ast_testing_string