DOP-2638: Handle escaped double-quotes

Author: i80and

snooty/rstparser.py

@@ -92,7 +92,12 @@ def unescape_backslashes(text: str) -> str:
     """docutils replaces backslashes with null characters. Deal with this in
     a fairly inane way that matches how backslashes seem to be used in our
     corpus."""
-    return text.replace("\x00<", "<").replace("\x00>", ">").replace("\x00", "\\")
+    return (
+        text.replace("\x00<", "<")
+        .replace("\x00>", ">")
+        .replace('\x00"', '"')
+        .replace("\x00", "\\")
+    )
 
 
 def parse_explicit_title(text: str) -> Tuple[str, Optional[str]]:

snooty/test_postprocess.py

@@ -2245,3 +2245,42 @@ def test_targets_with_backslashes() -> None:
 </root>
 """,
         )
+
+
+def test_target_quotes() -> None:
+    with make_test(
+        {
+            Path(
+                "source/index.txt"
+            ): r"""
+:writeconcern:`majority <\"majority\">`
+:writeconcern:`majority <"majority">`
+
+.. writeconcern:: "majority"
+"""
+        }
+    ) as result:
+        assert not result.diagnostics[FileId("index.txt")]
+        print(ast_to_testing_string(result.pages[FileId("index.txt")].ast))
+
+        check_ast_testing_string(
+            result.pages[FileId("index.txt")].ast,
+            """
+    <root fileid="index.txt">
+    <paragraph>
+        <ref_role domain="mongodb" name="writeconcern" target="writeconcern.&quot;majority&quot;" fileid="['index', 'mongodb-writeconcern-writeconcern.-majority-']">
+            <literal><text>majority</text></literal>
+        </ref_role><text></text>
+        <ref_role domain="mongodb" name="writeconcern" target="writeconcern.&quot;majority&quot;" fileid="['index', 'mongodb-writeconcern-writeconcern.-majority-']">
+            <literal><text>majority</text></literal>
+        </ref_role>
+    </paragraph>
+
+    <target domain="mongodb" name="writeconcern" html_id="mongodb-writeconcern-writeconcern.-majority-">
+        <directive_argument><literal><text>"majority"</text></literal></directive_argument>
+        <target_identifier ids="['writeconcern.&quot;majority&quot;']">
+            <text>"majority"</text>
+        </target_identifier>
+    </target>
+</root>""",
+        )