DOP-1056: Don't pop the top node on the stack upon InvalidURL

Author: i80and

CHANGELOG.md

@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 
 - Support for links in step file headings (DOP-1015).
+- Incorrect AST output with hyperlink references (DOP-1056).
 
 ## [v0.4.4] - 2020-04-21
 

snooty/parser.py

@@ -330,8 +330,6 @@ def dispatch_visit(self, node: docutils.nodes.Node) -> None:
 
             if not node["ids"]:
                 self.diagnostics.append(InvalidURL(util.get_line(node)))
-                # Remove the malformed node so it doesn't cause problems down the road
-                self.state.pop()
                 raise docutils.nodes.SkipNode()
 
             node_id = node["ids"][0]

snooty/test_parser.py

@@ -1110,7 +1110,7 @@ def test_callable_target() -> None:
     )
 
 
-def test_no_weird_targets() -> None:
+def test_no_hyperlink_references() -> None:
     path = ROOT_PATH.joinpath(Path("test.rst"))
     project_config = ProjectConfig(ROOT_PATH, "", source="./")
     parser = rstparser.Parser(project_config, JSONVisitor)
@@ -1132,6 +1132,16 @@ def test_no_weird_targets() -> None:
         diagnostics[1], InvalidURL
     )
 
+    check_ast_testing_string(
+        page.ast,
+        """
+    <root>
+    <paragraph><reference refname="ios-universal-links"><text>universal link</text></reference></paragraph>
+    <paragraph><reference refname="ios-universal-links"><text>universal link</text></reference></paragraph>
+    </root>
+    """,
+    )
+
 
 def test_dates() -> None:
     path = ROOT_PATH.joinpath(Path("test.rst"))