Have a separate Named Reference mapping for each .txt context

Author: i80and

snooty/postprocess.py

@@ -374,13 +374,13 @@ class NamedReferenceHandlerPass1(Handler):
 
     def __init__(self, context: Context) -> None:
         super().__init__(context)
-        self.named_references: Dict[str, str] = {}
+        self.named_references: Dict[FileId, Dict[str, str]] = defaultdict(dict)
 
     def enter_node(self, fileid_stack: FileIdStack, node: n.Node) -> None:
         if not isinstance(node, n.NamedReference):
             return
 
-        self.named_references[node.refname] = node.refuri
+        self.named_references[fileid_stack.root][node.refname] = node.refuri
 
 
 class NamedReferenceHandlerPass2(Handler):
@@ -396,8 +396,10 @@ def enter_node(self, fileid_stack: FileIdStack, node: n.Node) -> None:
             # Node is already populated with url; nothing to do
             return
 
-        refuri = self.context[NamedReferenceHandlerPass1].named_references.get(
-            node.refname
+        refuri = (
+            self.context[NamedReferenceHandlerPass1]
+            .named_references[fileid_stack.root]
+            .get(node.refname)
         )
         if refuri is None:
             line = node.span[0]

snooty/test_postprocess.py

@@ -1774,6 +1774,15 @@ def test_named_references() -> None:
 
 Reference `GitHub`_
 """,
+            # Should not be able to link to a named reference from another .txt
+            Path(
+                "source/foo.txt"
+            ): """
+.. include:: /fact-reference.rst
+
+`docs link`_
+""",
+            Path("source/fact-reference.rst"): "`docs link`_",
         },
     ) as result:
 
@@ -1856,6 +1865,14 @@ def test_named_references() -> None:
 """,
         )
 
+        # Should not be able to link to a named reference from another .txt
+        active_file = "foo.txt"
+        diagnostics = result.diagnostics[FileId(active_file)]
+        assert len(diagnostics) == 1
+        active_file = "fact-reference.rst"
+        diagnostics = result.diagnostics[FileId(active_file)]
+        assert len(diagnostics) == 1
+
 
 def test_contents_directive() -> None:
     with make_test(