DOP-2613: Handle unicode decode errors in literalinclude

Author: i80and

snooty/parser.py

@@ -720,14 +720,15 @@ def create_page() -> Tuple[Page, EmbeddedRstParser]:
 
             # Attempt to read the literally included file
             try:
-                with open(filepath) as file:
-                    text = file.read()
-
+                text = filepath.read_text(encoding="utf-8")
             except OSError as err:
                 self.diagnostics.append(
                     CannotOpenFile(argument_text, err.strerror, line)
                 )
                 return doc
+            except UnicodeDecodeError as err:
+                self.diagnostics.append(CannotOpenFile(argument_text, str(err), line))
+                return doc
 
             lines = text.split("\n")
 

snooty/test_parser.py

@@ -703,6 +703,20 @@ def test_literalinclude() -> None:
     assert len(diagnostics) == 1
     assert isinstance(diagnostics[0], DocUtilsParseError)
 
+    # Test non-textual
+    page, diagnostics = parse_rst(
+        parser,
+        path,
+        """
+.. literalinclude:: /compass-explain-plan-with-index-raw-json.png
+        """,
+    )
+    page.finish(diagnostics)
+    assert len(diagnostics) == 1
+    assert [(type(d), "utf-8" in d.message) for d in diagnostics] == [
+        (CannotOpenFile, True)
+    ]
+
 
 def test_include() -> None:
     path = ROOT_PATH.joinpath(Path("test.rst"))