INTMDB-867: [Terraform] Fix backup tests (#1236)

* Update resource_mongodbatlas_advanced_cluster_test.go

* Update resource_mongodbatlas_cloud_backup_schedule_test.go

* Revert "Update resource_mongodbatlas_cloud_backup_schedule_test.go"

This reverts commit 8850f3f.

* Update resource_mongodbatlas_cloud_backup_schedule.go

* Revert "Update resource_mongodbatlas_cloud_backup_schedule.go"

This reverts commit 25f6e5c.

* updated tests

* fixed logic

* Update resource_mongodbatlas_cloud_backup_schedule_test.go

* Update resource_mongodbatlas_cloud_backup_schedule.go

* Update resource_mongodbatlas_online_archive_test.go

Author: andreaangiolillo

mongodbatlas/resource_mongodbatlas_cloud_backup_schedule.go

@@ -402,6 +402,8 @@ func resourceMongoDBAtlasCloudBackupScheduleDelete(ctx context.Context, d *schem
 		return diag.Errorf("error deleting MongoDB Cloud Backup Schedule (%s): %s", clusterName, err)
 	}
 
+	d.SetId("")
+
 	return nil
 }
 
@@ -438,14 +440,30 @@ func resourceMongoDBAtlasCloudBackupScheduleImportState(ctx context.Context, d *
 }
 
 func cloudBackupScheduleCreateOrUpdate(ctx context.Context, conn *matlas.Client, d *schema.ResourceData, projectID, clusterName string) error {
-	req := &matlas.CloudProviderSnapshotBackupPolicy{}
+	_, policyMonthlyOK := d.GetOk("policy_item_monthly")
+	_, policyWeeklyOK := d.GetOk("policy_item_weekly")
+	_, policyDailyOK := d.GetOk("policy_item_daily")
+	_, policyhourlyOK := d.GetOk("policy_item_hourly")
+
+	// When a new cluster is created with the backup feature enabled,
+	// MongoDB Atlas automatically generates a default backup policy for that cluster.
+	// However, in the scenario where the user hasn't provided a backup policy,
+	// we want to make sure that the default backup policy is removed first.
+	// This is to avoid having the infrastructure differs from the TF configuration file.
+	if !policyMonthlyOK && !policyWeeklyOK && !policyDailyOK && !policyhourlyOK {
+		_, _, err := conn.CloudProviderSnapshotBackupPolicies.Delete(ctx, projectID, clusterName)
+		if err != nil {
+			log.Printf("error deleting MongoDB Cloud Backup Schedule (%s): %s", clusterName, err)
+		}
+	}
 
 	// Get policies items
 	resp, _, err := conn.CloudProviderSnapshotBackupPolicies.Get(ctx, projectID, clusterName)
 	if err != nil {
 		log.Printf("error getting MongoDB Cloud Backup Schedule (%s): %s", clusterName, err)
 	}
 
+	req := &matlas.CloudProviderSnapshotBackupPolicy{}
 	policy := matlas.Policy{}
 	policyItem := matlas.PolicyItem{}
 	var policiesItem []matlas.PolicyItem

mongodbatlas/resource_mongodbatlas_online_archive_test.go

@@ -25,7 +25,7 @@ const (
 		replication_specs {
 		  num_shards = 1
 		  regions_config {
-			 region_name     = "US_EAST_2"
+			 region_name     = "US_EAST_1"
 			 electable_nodes = 3
 			 priority        = 7
 			 read_only_nodes = 0