INTMDB-556: Regression in 1.8.0: mongodbatlas_third_party_integration marks "type" attribute as deprecated (#1034)

* Update CHANGELOG.md

* Chore(deps): Bump golangci/golangci-lint-action from 3.3.1 to 3.4.0 (#1026)

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.3.1 to 3.4.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v3.3.1...v3.4.0)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add warning for deprecated integration types

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Author: 3 people

mongodbatlas/resource_mongodbatlas_third_party_integration.go

@@ -6,9 +6,9 @@ import (
 	"net/http"
 	"regexp"
 
+	"github.com/hashicorp/go-cty/cty"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
-	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
 )
 
 var integrationTypes = []string{
@@ -23,6 +23,11 @@ var integrationTypes = []string{
 	"PROMETHEUS",
 }
 
+var deprecatedIntegrationTypes = []string{
+	"NEW_RELIC",
+	"FLOWDOCK",
+}
+
 var requiredPerType = map[string][]string{
 	"PAGER_DUTY":      {"service_key"},
 	"DATADOG":         {"api_key", "region"},
@@ -51,11 +56,10 @@ func resourceMongoDBAtlasThirdPartyIntegration() *schema.Resource {
 				ForceNew: true,
 			},
 			"type": {
-				Type:         schema.TypeString,
-				Required:     true,
-				ForceNew:     true,
-				ValidateFunc: validation.StringInSlice(integrationTypes, false),
-				Deprecated:   "This field type has values (NEW_RELIC, FLOWDOCK) that are deprecated and will be removed in 1.9.0 release ",
+				Type:             schema.TypeString,
+				Required:         true,
+				ForceNew:         true,
+				ValidateDiagFunc: validateIntegrationType(),
 			},
 			"license_key": {
 				Type:      schema.TypeString,
@@ -310,3 +314,36 @@ func splitIntegrationTypeID(id string) (projectID, integrationType string, err e
 
 	return
 }
+
+func validateIntegrationType() schema.SchemaValidateDiagFunc {
+	return func(v any, p cty.Path) diag.Diagnostics {
+		value := v.(string)
+		var diags diag.Diagnostics
+		if !isElementExist(integrationTypes, value) {
+			diagError := diag.Diagnostic{
+				Severity: diag.Error,
+				Summary:  "Invalid Third Party Integration type",
+				Detail:   fmt.Sprintf("Third Party integration type %q is not a valid value. Possible values are: %q.", value, integrationTypes),
+			}
+			diags = append(diags, diagError)
+		}
+		if isElementExist(deprecatedIntegrationTypes, value) {
+			diagWarn := diag.Diagnostic{
+				Severity: diag.Warning,
+				Summary:  "Warning deprecated Third Party Integration type",
+				Detail:   fmt.Sprintf("Third Party integration type %q is a deprecated value. This field type values %q are deprecated and will be removed in 1.9.0 release", value, deprecatedIntegrationTypes),
+			}
+			diags = append(diags, diagWarn)
+		}
+		return diags
+	}
+}
+
+func isElementExist(s []string, str string) bool {
+	for _, v := range s {
+		if v == str {
+			return true
+		}
+	}
+	return false
+}