fix: define ConfigMode for computed nest block attribute in privatelink_endpoint_service to support tf 1.0.8 (#1629)

* fix: define ConfigMode for computed nest block attribute in privatelink_endpoint_service to support tf 1.0.8

* move configuration of providers from step to general test case to avoid duplication

Author: AgustinBettati

mongodbatlas/resource_mongodbatlas_privatelink_endpoint_service.go

@@ -103,6 +103,7 @@ func resourceMongoDBAtlasPrivateEndpointServiceLink() *schema.Resource {
 				Optional:      true,
 				Computed:      true,
 				ConflictsWith: []string{"private_endpoint_ip_address"},
+				ConfigMode:    schema.SchemaConfigModeAttr,
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
 						"status": {

mongodbatlas/resource_mongodbatlas_privatelink_endpoint_service_migration_test.go

@@ -0,0 +1,75 @@
+package mongodbatlas
+
+import (
+	"fmt"
+	"os"
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
+	"github.com/hashicorp/terraform-plugin-testing/plancheck"
+)
+
+func TestAccMigrationNetworkRSPrivateLinkEndpointService_Complete(t *testing.T) {
+	SkipTestExtCred(t)
+	var (
+		resourceSuffix = "test"
+		resourceName   = fmt.Sprintf("mongodbatlas_privatelink_endpoint_service.%s", resourceSuffix)
+
+		awsAccessKey = os.Getenv("AWS_ACCESS_KEY_ID")
+		awsSecretKey = os.Getenv("AWS_SECRET_ACCESS_KEY")
+
+		providerName          = "AWS"
+		projectID             = os.Getenv("MONGODB_ATLAS_PROJECT_ID")
+		region                = os.Getenv("AWS_REGION")
+		vpcID                 = os.Getenv("AWS_VPC_ID")
+		subnetID              = os.Getenv("AWS_SUBNET_ID")
+		securityGroupID       = os.Getenv("AWS_SECURITY_GROUP_ID")
+		lastVersionConstraint = os.Getenv("MONGODB_ATLAS_LAST_VERSION")
+	)
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheck(t); testCheckAwsEnv(t) },
+		CheckDestroy: testAccCheckMongoDBAtlasPrivateLinkEndpointServiceDestroy,
+		Steps: []resource.TestStep{
+			{
+				ExternalProviders: map[string]resource.ExternalProvider{
+					"mongodbatlas": {
+						VersionConstraint: lastVersionConstraint,
+						Source:            "mongodb/mongodbatlas",
+					},
+					"aws": {
+						VersionConstraint: "5.1.0",
+						Source:            "hashicorp/aws",
+					},
+				},
+				Config: testAccMongoDBAtlasPrivateLinkEndpointServiceConfigCompleteAWS(
+					awsAccessKey, awsSecretKey, projectID, providerName, region, vpcID, subnetID, securityGroupID, resourceSuffix,
+				),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckMongoDBAtlasPrivateLinkEndpointServiceExists(resourceName),
+					resource.TestCheckResourceAttrSet(resourceName, "project_id"),
+					resource.TestCheckResourceAttrSet(resourceName, "private_link_id"),
+					resource.TestCheckResourceAttrSet(resourceName, "endpoint_service_id"),
+				),
+			},
+			{
+				ExternalProviders: map[string]resource.ExternalProvider{
+					"aws": {
+						VersionConstraint: "5.1.0",
+						Source:            "hashicorp/aws",
+					},
+				},
+				ProtoV6ProviderFactories: testAccProviderV6Factories,
+				Config: testAccMongoDBAtlasPrivateLinkEndpointServiceConfigCompleteAWS(
+					awsAccessKey, awsSecretKey, projectID, providerName, region, vpcID, subnetID, securityGroupID, resourceSuffix,
+				),
+				ConfigPlanChecks: resource.ConfigPlanChecks{
+					PostApplyPreRefresh: []plancheck.PlanCheck{
+						DebugPlan(),
+					},
+				},
+				PlanOnly: true,
+			},
+		},
+	})
+}

mongodbatlas/resource_mongodbatlas_privatelink_endpoint_service_test.go

@@ -29,8 +29,14 @@ func TestAccNetworkRSPrivateLinkEndpointServiceAWS_Complete(t *testing.T) {
 
 	resource.Test(t, resource.TestCase{
 		PreCheck:                 func() { testAccPreCheck(t); testCheckAwsEnv(t) },
-		ProtoV6ProviderFactories: testAccProviderV6Factories,
 		CheckDestroy:             testAccCheckMongoDBAtlasPrivateLinkEndpointServiceDestroy,
+		ProtoV6ProviderFactories: testAccProviderV6Factories,
+		ExternalProviders: map[string]resource.ExternalProvider{
+			"aws": {
+				VersionConstraint: "5.1.0",
+				Source:            "hashicorp/aws",
+			},
+		},
 		Steps: []resource.TestStep{
 			{
 				Config: testAccMongoDBAtlasPrivateLinkEndpointServiceConfigCompleteAWS(
@@ -66,8 +72,14 @@ func TestAccNetworkRSPrivateLinkEndpointServiceAWS_import(t *testing.T) {
 
 	resource.Test(t, resource.TestCase{
 		PreCheck:                 func() { testAccPreCheck(t); testCheckAwsEnv(t) },
-		ProtoV6ProviderFactories: testAccProviderV6Factories,
 		CheckDestroy:             testAccCheckMongoDBAtlasPrivateLinkEndpointServiceDestroy,
+		ProtoV6ProviderFactories: testAccProviderV6Factories,
+		ExternalProviders: map[string]resource.ExternalProvider{
+			"aws": {
+				VersionConstraint: "5.1.0",
+				Source:            "hashicorp/aws",
+			},
+		},
 		Steps: []resource.TestStep{
 			{
 				Config: testAccMongoDBAtlasPrivateLinkEndpointServiceConfigCompleteAWS(
@@ -106,7 +118,7 @@ func testAccCheckMongoDBAtlasPrivateLinkEndpointServiceImportStateIDFunc(resourc
 
 func testAccCheckMongoDBAtlasPrivateLinkEndpointServiceExists(resourceName string) resource.TestCheckFunc {
 	return func(s *terraform.State) error {
-		conn := testAccProviderSdkV2.Meta().(*MongoDBClient).Atlas
+		conn := testMongoDBClient.(*MongoDBClient).Atlas
 
 		rs, ok := s.RootModule().Resources[resourceName]
 		if !ok {
@@ -129,7 +141,7 @@ func testAccCheckMongoDBAtlasPrivateLinkEndpointServiceExists(resourceName strin
 }
 
 func testAccCheckMongoDBAtlasPrivateLinkEndpointServiceDestroy(s *terraform.State) error {
-	conn := testAccProviderSdkV2.Meta().(*MongoDBClient).Atlas
+	conn := testMongoDBClient.(*MongoDBClient).Atlas
 
 	for _, rs := range s.RootModule().Resources {
 		if rs.Type != "mongodbatlas_privatelink_endpoint_service" {