test: Updates all test workflows to use advanced_cluster TPF implementation (#3580)

Author: maastha

.github/workflows/acceptance-tests-runner.yml

@@ -242,7 +242,6 @@ jobs:
       mustTrigger: ${{ github.event_name == 'schedule' || (github.event_name == 'workflow_dispatch' && inputs.test_group == '' )  }}
     outputs: # ensure resources are sorted alphabetically
       advanced_cluster: ${{ steps.filter.outputs.advanced_cluster == 'true' || env.mustTrigger == 'true' }}
-      advanced_cluster_tpf: ${{ steps.filter.outputs.advanced_cluster_tpf == 'true' || env.mustTrigger == 'true' }}
       assume_role: ${{ steps.filter.outputs.assume_role == 'true' || env.mustTrigger == 'true' }}
       autogen: ${{ steps.filter.outputs.autogen == 'true' || env.mustTrigger == 'true' }}
       backup: ${{ steps.filter.outputs.backup == 'true' || env.mustTrigger == 'true' }}
@@ -275,11 +274,7 @@ jobs:
       with:
         filters: |
           advanced_cluster:
-            - 'internal/service/advancedcluster/!(*_test).go' # matches any adv_cluster file change except test files
-            - 'internal/service/advancedclustertpf/common*.go'
-          advanced_cluster_tpf:
             - 'internal/service/advancedclustertpf/*.go'
-            - 'internal/service/advancedcluster/*_test.go'
           assume_role:
             - 'internal/provider/*.go'
           autogen:
@@ -386,9 +381,9 @@ jobs:
             - 'internal/service/streamprivatelinkendpoint/*.go'
 
 
-  advanced_cluster_tpf:
+  advanced_cluster:
     needs: [ change-detection, get-provider-version ]
-    if: ${{ needs.change-detection.outputs.advanced_cluster_tpf == 'true' || inputs.test_group == 'advanced_cluster_tpf' }}
+    if: ${{ needs.change-detection.outputs.advanced_cluster == 'true' || inputs.test_group == 'advanced_cluster' }}
     runs-on: ubuntu-latest
     permissions: {}
     steps:
@@ -409,13 +404,12 @@ jobs:
           HTTP_MOCKER_CAPTURE: 'true'
           ACCTEST_REGEX_RUN: ${{ inputs.reduced_tests && '^TestAccMockable' || env.ACCTEST_REGEX_RUN }}
           ACCTEST_PACKAGES: |
-            ./internal/service/advancedcluster
             ./internal/service/advancedclustertpf
         run: make testacc
 
   advanced_cluster_tpf_mig_from_sdkv2:
     needs: [ change-detection, get-provider-version ]
-    if: ${{ inputs.reduced_tests == false && (needs.change-detection.outputs.advanced_cluster_tpf == 'true' || inputs.test_group == 'advanced_cluster_tpf') }}
+    if: ${{ inputs.reduced_tests == false && (needs.change-detection.outputs.advanced_cluster == 'true' || inputs.test_group == 'advanced_cluster') }}
     env:
       MONGODB_ATLAS_TEST_SDKV2_TO_TPF: 'true'
     runs-on: ubuntu-latest
@@ -437,7 +431,7 @@ jobs:
           MONGODB_ATLAS_LAST_1X_VERSION: ${{ inputs.mongodb_atlas_last_1x_version }}
           ACCTEST_REGEX_RUN: '^TestMig'
           ACCTEST_PACKAGES: |
-            ./internal/service/advancedcluster
+            ./internal/service/advancedclustertpf
         run: make testacc
 
   assume_role:

.github/workflows/code-health.yml

@@ -91,4 +91,4 @@ jobs:
     secrets: inherit
     uses: ./.github/workflows/acceptance-tests.yml
     with:
-        reduced_tests: false
+        reduced_tests: true

internal/config/preview_provider_v2.go

@@ -6,6 +6,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-testing/knownvalue"
 	"github.com/hashicorp/terraform-plugin-testing/plancheck"
 	"github.com/hashicorp/terraform-plugin-testing/tfjsonpath"
+
 	"github.com/mongodb/terraform-provider-mongodbatlas/internal/testutil/unit"
 )
 
@@ -14,7 +15,6 @@ var (
 	repSpec1      = tfjsonpath.New("replication_specs").AtSliceIndex(1)
 	regionConfig0 = repSpec0.AtMapKey("region_configs").AtSliceIndex(0)
 	regionConfig1 = repSpec1.AtMapKey("region_configs").AtSliceIndex(0)
-	mockConfig    = unit.MockConfigAdvancedClusterTPF
 )
 
 func autoScalingKnownValue(computeEnabled, diskEnabled, scaleDown bool, minInstanceSize, maxInstanceSize string) knownvalue.Check {

internal/service/advancedcluster/move_state_test.go

@@ -1,4 +1,4 @@
-package advancedcluster_test
+package advancedclustertpf_test
 
 import (
 	"os"

internal/service/advancedcluster/resource_advanced_cluster_state_upgrader_test.go

@@ -1,6 +1,7 @@
-package advancedcluster_test
+package advancedclustertpf_test
 
 import (
+	"errors"
 	"fmt"
 	"net/http"
 	"os"
@@ -62,6 +63,7 @@ var (
 	configServerManagementModeFixedToDedicated = "FIXED_TO_DEDICATED"
 	configServerManagementModeAtlasManaged     = "ATLAS_MANAGED"
 	mockConfig                                 = unit.MockConfigAdvancedClusterTPF
+	errGeneric                                 = errors.New("generic")
 )
 
 func TestGetReplicationSpecAttributesFromOldAPI(t *testing.T) {