Empty/nil test cases

Author: Cristina Sánchez Sánchez

internal/service/clouduserprojectassignment/model.go

@@ -38,7 +38,7 @@ func NewTFModel(ctx context.Context, projectID string, apiResp *admin.GroupUserR
 }
 
 func NewProjectUserReq(ctx context.Context, plan *TFModel) (*admin.GroupUserRequest, diag.Diagnostics) {
-	var roleNames []string
+	roleNames := []string{}
 	if !plan.Roles.IsNull() && !plan.Roles.IsUnknown() {
 		roleNames = conversion.TypesSetToString(ctx, plan.Roles)
 	}

internal/service/clouduserprojectassignment/model_test.go

@@ -4,6 +4,7 @@ import (
 	"testing"
 	"time"
 
+	"github.com/hashicorp/terraform-plugin-framework/attr"
 	"github.com/hashicorp/terraform-plugin-framework/types"
 	"github.com/mongodb/terraform-provider-mongodbatlas/internal/service/clouduserprojectassignment"
 	"github.com/stretchr/testify/assert"
@@ -92,6 +93,39 @@ func TestCloudUserProjectAssignmentSDKToTFModel(t *testing.T) {
 			SDKResp:         fullResp,
 			expectedTFModel: expectedFullModel,
 		},
+		"Empty SDK response": {
+			SDKResp: &admin.GroupUserResponse{
+				Id:                  "",
+				Username:            "",
+				FirstName:           nil,
+				LastName:            nil,
+				Country:             nil,
+				MobileNumber:        nil,
+				OrgMembershipStatus: "",
+				CreatedAt:           nil,
+				LastAuth:            nil,
+				InvitationCreatedAt: nil,
+				InvitationExpiresAt: nil,
+				InviterUsername:     nil,
+				Roles:               nil,
+			},
+			expectedTFModel: &clouduserprojectassignment.TFModel{
+				UserId:              types.StringValue(""),
+				Username:            types.StringValue(""),
+				ProjectId:           types.StringValue(testProjectID),
+				FirstName:           types.StringNull(),
+				LastName:            types.StringNull(),
+				Country:             types.StringNull(),
+				MobileNumber:        types.StringNull(),
+				OrgMembershipStatus: types.StringValue(""),
+				CreatedAt:           types.StringNull(),
+				LastAuth:            types.StringNull(),
+				InvitationCreatedAt: types.StringNull(),
+				InvitationExpiresAt: types.StringNull(),
+				InviterUsername:     types.StringNull(),
+				Roles:               types.SetNull(types.StringType),
+			},
+		},
 	}
 
 	for testName, tc := range testCases {
@@ -133,6 +167,26 @@ func TestNewProjectUserRequest(t *testing.T) {
 				Roles:    testProjectRoles,
 			},
 		},
+		"Nil model": {
+			plan: &clouduserprojectassignment.TFModel{
+				Username: types.StringNull(),
+				Roles:    types.SetNull(types.StringType),
+			},
+			expected: &admin.GroupUserRequest{
+				Username: "",
+				Roles:    []string{},
+			},
+		},
+		"Empty model": {
+			plan: &clouduserprojectassignment.TFModel{
+				Username: types.StringValue(""),
+				Roles:    types.SetValueMust(types.StringType, []attr.Value{}),
+			},
+			expected: &admin.GroupUserRequest{
+				Username: "",
+				Roles:    []string{},
+			},
+		},
 	}
 
 	for name, tc := range testCases {
@@ -193,6 +247,15 @@ func TestNewAtlasUpdateReq(t *testing.T) {
 			wantAddRoles:    []string{"GROUP_OWNER"},
 			wantRemoveRoles: []string{},
 		},
+		{
+			name: "nil roles",
+			args: args{
+				stateRoles: nil,
+				planRoles:  []string{},
+			},
+			wantAddRoles:    []string{},
+			wantRemoveRoles: []string{},
+		},
 	}
 
 	for _, tt := range tests {