Skip to content

Commit 5b80c57

Browse files
oarbusiAgustinBettatijwilliams-mongo
authored
remove!: Removes items_per_page and page_num from data_source_privatelink_endpoints_service_serverless (#2336)
* remove items_per_page and page_num * update upgrade guide * fix changelog entry * Update .changelog/2336.txt Co-authored-by: Agustin Bettati <[email protected]> * correct datasource name * fix * Update website/docs/guides/1.17.0-upgrade-guide.html.markdown Co-authored-by: John Williams <[email protected]> --------- Co-authored-by: Agustin Bettati <[email protected]> Co-authored-by: John Williams <[email protected]>
1 parent 484544d commit 5b80c57

File tree

3 files changed

+4
-12
lines changed

3 files changed

+4
-12
lines changed

.changelog/2336.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:breaking-change
2+
data-source/mongodbatlas_privatelink_endpoints_service_serverless: Removes `page_num` and `items_per_page` arguments
3+
```

internal/service/privatelinkendpointserviceserverless/data_source_privatelink_endpoints_service_serverless.go

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,10 @@ package privatelinkendpointserviceserverless
22

33
import (
44
"context"
5-
"fmt"
65

76
"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
87
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/id"
98
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
10-
"github.com/mongodb/terraform-provider-mongodbatlas/internal/common/constant"
119
"github.com/mongodb/terraform-provider-mongodbatlas/internal/config"
1210
"go.mongodb.org/atlas-sdk/v20231115014/admin"
1311
)
@@ -25,16 +23,6 @@ func PluralDataSource() *schema.Resource {
2523
Required: true,
2624
ForceNew: true,
2725
},
28-
"page_num": {
29-
Deprecated: fmt.Sprintf(constant.DeprecationParamByVersion, "1.17.0"),
30-
Type: schema.TypeInt,
31-
Optional: true,
32-
},
33-
"items_per_page": {
34-
Deprecated: fmt.Sprintf(constant.DeprecationParamByVersion, "1.17.0"),
35-
Type: schema.TypeInt,
36-
Optional: true,
37-
},
3826
"results": {
3927
Type: schema.TypeList,
4028
Computed: true,

website/docs/guides/1.17.0-upgrade-guide.html.markdown

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ The Terraform MongoDB Atlas Provider version 1.17.0 has a number of new and exci
2525
`terraform import mongodbatlas_federated_settings_identity_provider.identity_provider <federation_settings_id>-<idp_id>`
2626
3. Run `terraform plan`.
2727
4. Run `terraform apply`.
28+
- Attributes `page_num` and `items_per_page` removed from [`mongodbatlas_privatelink_endpoints_service_serverless`](https://registry.terraform.io/providers/mongodb/mongodbatlas/latest/docs/data-sources/privatelink_endpoints_service_serverless) data source.
2829

2930
### Helpful Links
3031

0 commit comments

Comments
 (0)