INTMDB-142: Fixes the bug for alertconfiguration using data dog (#366)

* fix: changed the name of struct for datadog api key

* test: added testacc for data dog aler configuration

Co-authored-by: Edgar López <[email protected]>

Author: coderGo93

mongodbatlas/resource_mongodbatlas_alert_configuration.go

@@ -593,7 +593,7 @@ func flattenAlertConfigurationNotifications(notifications []matlas.Notification)
 		nts[i] = map[string]interface{}{
 			"api_token":              notifications[i].APIToken,
 			"channel_name":           notifications[i].ChannelName,
-			"datadog_api_key":        notifications[i].DatadogRegion,
+			"datadog_api_key":        notifications[i].DatadogAPIKey,
 			"datadog_region":         notifications[i].DatadogRegion,
 			"delay_min":              notifications[i].DelayMin,
 			"email_address":          notifications[i].EmailAddress,

mongodbatlas/resource_mongodbatlas_alert_configuration_test.go

@@ -261,6 +261,33 @@ func TestAccResourceMongoDBAtlasAlertConfiguration_importConfigNotifications(t *
 	})
 }
 
+func TestAccResourceMongoDBAtlasAlertConfiguration_DataDog(t *testing.T) {
+	SkipTestExtCred(t) // Will skip because requires external credentials aka api key
+	SkipTest(t)        // Will force skip if enabled
+	var (
+		resourceName = "mongodbatlas_alert_configuration.test"
+		projectID    = os.Getenv("MONGODB_ATLAS_PROJECT_ID")
+		ddAPIKey     = os.Getenv("DD_API_KEY")
+		ddRegion     = "US"
+		alert        = &matlas.AlertConfiguration{}
+	)
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
+		CheckDestroy: testAccCheckMongoDBAtlasAlertConfigurationDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccMongoDBAtlasAlertConfigurationConfigWithDataDog(projectID, ddAPIKey, ddRegion, true),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckMongoDBAtlasAlertConfigurationExists(resourceName, alert),
+					resource.TestCheckResourceAttrSet(resourceName, "project_id"),
+				),
+			},
+		},
+	})
+}
+
 func testAccCheckMongoDBAtlasAlertConfigurationExists(resourceName string, alert *matlas.AlertConfiguration) resource.TestCheckFunc {
 	return func(s *terraform.State) error {
 		conn := testAccProvider.Meta().(*matlas.Client)
@@ -505,3 +532,49 @@ func testAccMongoDBAtlasAlertConfigurationConfigWithThresholdUpdated(projectID s
 		}
 	`, projectID, enabled, threshold)
 }
+
+func testAccMongoDBAtlasAlertConfigurationConfigWithDataDog(projectID, dataDogAPIKey, dataDogRegion string, enabled bool) string {
+	return fmt.Sprintf(`
+resource "mongodbatlas_third_party_integration" "atlas_datadog" {
+  project_id = "%[1]s"
+  type = "DATADOG"
+  api_key = "%[3]s"
+  region = "%[4]s"
+}
+
+resource "mongodbatlas_alert_configuration" "test" {
+  project_id = "%[1]s"
+  event_type = "REPLICATION_OPLOG_WINDOW_RUNNING_OUT"
+  enabled    = %t
+
+  notification {
+    type_name     = "GROUP"
+    interval_min  = 5
+    delay_min     = 0
+    sms_enabled   = false
+    email_enabled = true
+    roles         = ["GROUP_OWNER"]
+  }
+
+  notification {
+    type_name = "DATADOG"
+    datadog_api_key = mongodbatlas_third_party_integration.atlas_datadog.api_key
+    datadog_region = mongodbatlas_third_party_integration.atlas_datadog.region
+    interval_min  = 5
+    delay_min     = 0
+  }
+
+  matcher {
+    field_name = "HOSTNAME_AND_PORT"
+    operator   = "EQUALS"
+    value      = "SECONDARY"
+  }
+
+  threshold = {
+    operator    = "LESS_THAN"
+    threshold   = 72
+    units       = "HOURS"
+  }
+}
+	`, projectID, enabled, dataDogAPIKey, dataDogRegion)
+}