docs: cleanup in project_api_key docs, and unused code in resource (#1636)

Author: AgustinBettati

mongodbatlas/resource_mongodbatlas_project_api_key.go

@@ -191,17 +191,6 @@ func resourceMongoDBAtlasProjectAPIKeyUpdate(ctx context.Context, d *schema.Reso
 	projectID := ids["project_id"]
 	apiKeyID := ids["api_key_id"]
 
-	updateRequest := new(matlas.AssignAPIKey)
-	if d.HasChange("role_names") {
-		updateRequest.Roles = expandStringList(d.Get("role_names").(*schema.Set).List())
-		if updateRequest.Roles != nil {
-			_, err := conn.ProjectAPIKeys.Assign(ctx, projectID, apiKeyID, updateRequest)
-			if err != nil {
-				return diag.FromErr(fmt.Errorf("error updating API key: %s", err))
-			}
-		}
-	}
-
 	if d.HasChange("project_assignment") {
 		// Getting the current api_keys and the new api_keys with changes
 		newAPIKeys, changedAPIKeys, removedAPIKeys := getStateProjectAssignmentAPIKeys(d)

website/docs/d/project_api_key.html.markdown

@@ -19,16 +19,13 @@ description: |-
 ### Using org_id attribute to query
 ```terraform
 resource "mongodbatlas_project_api_key" "test" {
-  description   = "Description of the API key"
-  project_id    = "32b6e34b3d91647abb20e7b8"
   description   = "Description of the API key"
   project_id    = "32b6e34b3d91647abb20e7b8"
   role_names = ["GROUP_READ_ONLY"]
   }
 }
 
 data "mongodbatlas_project_api_key" "test" {
-  project_id = "${mongodbatlas_api_key.test.project_id}"
   api_key_id = "${mongodbatlas_api_key.test.api_key_id}"
 }
 ```

website/docs/r/project_api_key.html.markdown

@@ -31,17 +31,13 @@ resource "mongodbatlas_project_api_key" "test" {
 resource "mongodbatlas_project_api_key" "test" {
   description   = "Description of your API key"
   project_id  = "64259ee860c43338194b0f8e"
-  description   = "Description of your API key"
-  project_id  = "64259ee860c43338194b0f8e"
   
  project_assignment {
-    project_id = "64259ee860c43338194b0f8e"
     project_id = "64259ee860c43338194b0f8e"
     role_names = ["GROUP_READ_ONLY", "GROUP_OWNER"]
   }
   
   project_assignment {
-    project_id = "74259ee860c43338194b0f8e"
     project_id = "74259ee860c43338194b0f8e"
     role_names = ["GROUP_READ_ONLY"]
   }
@@ -58,7 +54,6 @@ resource "mongodbatlas_project_api_key" "test" {
 
 ### project_assignment
 List of Project roles that the Programmatic API key needs to have. `project_assignment` attribute is optional.
-List of Project roles that the Programmatic API key needs to have. `project_assignment` attribute is optional.
 
 * `project_id` - (Required) Project ID to assign to Access Key
 * `role_names` - (Required) List of Project roles that the Programmatic API key needs to have. Ensure you provide: at least one role and ensure all roles are valid for the Project. You must specify an array even if you are only associating a single role with the Programmatic API key. The [MongoDB Documentation](https://www.mongodb.com/docs/atlas/reference/user-roles/#project-roles) describes the valid roles that can be assigned.
@@ -77,4 +72,3 @@ API Keys must be imported using project ID, API Key ID e.g.
 $ terraform import mongodbatlas_project_api_key.test 5d09d6a59ccf6445652a444a-6576974933969669
 ```
 See [MongoDB Atlas API - API Key](https://www.mongodb.com/docs/atlas/reference/api-resources-spec/#tag/Programmatic-API-Keys/operation/createProjectApiKey) - Documentation for more information.
-See [MongoDB Atlas API - API Key](https://www.mongodb.com/docs/atlas/reference/api-resources-spec/#tag/Programmatic-API-Keys/operation/createProjectApiKey) - Documentation for more information.