chore: Adds deprecation notice for tenant_id attribute in mongodbatlas_cloud_backup_snapshot_export_bucket and remove deprecation on attribute to avoid warnings (#2938)

* chore: Add deprecation notice for `tenant_id` attribute in `mongodbatlas_cloud_backup_snapshot_export_bucket`

* chore: Remove deprecation notice for data sources of `tenant_id` attribute in cloud backup snapshot export bucket documentation

* chore: Update deprecation notice for `tenant_id` in cloud backup snapshot export bucket documentation and schema

* chore: Remove deprecation notice for `tenant_id` in resource to avoid warnings when used as an attribute

* chore: Clean up formatting for `tenant_id` attribute in cloud backup snapshot export bucket schema

* chore: Update comment for `tenant_id` attribute to clarify its computed usage and potential breaking change

Author: EspenAlbert

.changelog/2932.txt

@@ -0,0 +1,3 @@
+```release-note:note
+resource/mongodbatlas_cloud_backup_snapshot_export_bucket: Deprecates `tenant_id` argument as the `mongodbatlas_cloud_provider_access_authorization.azure.tenant_id` is used instead
+```

docs/data-sources/cloud_backup_snapshot_export_bucket.md

@@ -35,7 +35,7 @@ In addition to all arguments above, the following attributes are exported:
 * `cloud_provider` - Name of the provider of the cloud service where Atlas can access the S3 bucket.
 * `role_id` - Unique identifier of the Azure Service Principal that Atlas can use to access the Azure Blob Storage Container.
 * `service_url` - URL that identifies the blob Endpoint of the Azure Blob Storage Account.
-* `tenant_id` - (Deprecated) This field is ignored; the `mongodbatlas_cloud_provider_access_authorization.azure.tenant_id` is used instead. UUID that identifies the Azure Active Directory Tenant ID.
+* `tenant_id` - UUID that identifies the Azure Active Directory Tenant ID.
 
 
 

docs/data-sources/cloud_backup_snapshot_export_buckets.md

@@ -44,7 +44,7 @@ In addition to all arguments above, the following attributes are exported:
 * `cloud_provider` - Name of the provider of the cloud service where Atlas can access the S3 bucket.
 * `role_id` - Unique identifier of the Azure Service Principal that Atlas can use to access the Azure Blob Storage Container.
 * `service_url` - URL that identifies the blob Endpoint of the Azure Blob Storage Account.
-* `tenant_id` - (Deprecated) This field is ignored; the `mongodbatlas_cloud_provider_access_authorization.azure.tenant_id` is used instead. UUID that identifies the Azure Active Directory Tenant ID.
+* `tenant_id` - UUID that identifies the Azure Active Directory Tenant ID.
 
 
 For more information see: [MongoDB Atlas API Reference.](https://docs.atlas.mongodb.com/reference/api/cloud-backup/export/create-one-export-bucket/)

docs/resources/cloud_backup_snapshot_export_bucket.md

@@ -39,13 +39,14 @@ resource "mongodbatlas_cloud_backup_snapshot_export_bucket" "test" {
 * `iam_role_id` - Unique identifier of the role that Atlas can use to access the bucket. Required if `cloud_provider` is set to `AWS`.
 * `role_id` - Unique identifier of the Azure Service Principal that Atlas can use to access the Azure Blob Storage Container. Required if `cloud_provider` is set to `AZURE`.
 * `service_url` - URL that identifies the blob Endpoint of the Azure Blob Storage Account. Required if `cloud_provider` is set to `AZURE`.
-* `tenant_id` - (Deprecated) This field is ignored; the `mongodbatlas_cloud_provider_access_authorization.azure.tenant_id` is used instead. UUID that identifies the Azure Active Directory Tenant ID.
+* `tenant_id` - (Deprecated) This field is ignored; the `mongodbatlas_cloud_provider_access_authorization.azure.tenant_id` is used instead and returned as an attribute. UUID that identifies the Azure Active Directory Tenant ID.
 
 ## Attributes Reference
 
 In addition to all arguments above, the following attributes are exported:
 
 * `export_bucket_id` - Unique identifier of the snapshot export bucket.
+* `tenant_id` - UUID that identifies the Azure Active Directory Tenant ID.
 
 ## Import
 

internal/service/cloudbackupsnapshotexportbucket/resource_cloud_backup_snapshot_export_bucket.go

@@ -15,7 +15,6 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/retry"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 
-	"github.com/mongodb/terraform-provider-mongodbatlas/internal/common/constant"
 	"github.com/mongodb/terraform-provider-mongodbatlas/internal/common/conversion"
 	"github.com/mongodb/terraform-provider-mongodbatlas/internal/config"
 )
@@ -73,10 +72,9 @@ func Schema() map[string]*schema.Schema {
 			ForceNew: true,
 		},
 		"tenant_id": {
-			Deprecated: fmt.Sprintf(constant.DeprecationParamByVersion, "1.27.0") + " This field is ignored; the `mongodbatlas_cloud_provider_access_authorization.azure.tenant_id` is used instead.",
-			Type:       schema.TypeString,
-			Optional:   true,
-			Computed:   true,
+			Type:     schema.TypeString,
+			Optional: true, // attribute is only used as a computed, this is called out in docs and configuration of optional argument can be eventually removed implying a breaking change. To be removed in https://jira.mongodb.org/browse/CLOUDP-293142
+			Computed: true,
 		},
 	}
 }

internal/service/cloudbackupsnapshotexportbucket/resource_cloud_backup_snapshot_export_bucket_test.go

@@ -91,6 +91,7 @@ func basicAzureTestCase(t *testing.T) *resource.TestCase {
 			"project_id":     projectID,
 			"bucket_name":    bucketName,
 			"service_url":    serviceURL,
+			"tenant_id":      tenantID,
 			"cloud_provider": "AZURE",
 		}
 		pluralAttrMapCheck = map[string]string{
@@ -99,6 +100,7 @@ func basicAzureTestCase(t *testing.T) *resource.TestCase {
 			"results.0.bucket_name":    bucketName,
 			"results.0.service_url":    serviceURL,
 			"results.0.cloud_provider": "AZURE",
+			"results.0.tenant_id":      tenantID,
 		}
 		attrsSet = []string{
 			"role_id",