chore: Fix send_notification in Test Suite (#3792)

Author: lantoli

.github/workflows/acceptance-tests-runner.yml

@@ -1330,7 +1330,7 @@ jobs:
 
   slack-notification-stream:
     needs: [stream]
-    if: ${{ !cancelled() && needs.stream.result == 'failure' && inputs.send_notification == true }}
+    if: ${{ !cancelled() && needs.stream.result == 'failure' && !contains(github.event.inputs.send_notification, 'false') }}
     runs-on: ubuntu-latest
     permissions: {}
     steps:

.github/workflows/acceptance-tests.yml

@@ -127,7 +127,7 @@ jobs:
       test_name: ${{ inputs.test_name }}
       reduced_tests: ${{ inputs.reduced_tests || false }}
       use_sa: ${{ inputs.use_sa || false }}
-      send_notification: ${{ inputs.send_notification || false }}
+      send_notification: ${{ !contains(github.event.inputs.send_notification, 'false') }}
       aws_region_federation: ${{ vars.AWS_REGION_FEDERATION }}
       mongodb_atlas_org_id: ${{ inputs.atlas_cloud_env == 'qa' && vars.MONGODB_ATLAS_ORG_ID_CLOUD_QA || vars.MONGODB_ATLAS_ORG_ID_CLOUD_DEV }}
       mongodb_atlas_base_url: ${{ inputs.atlas_cloud_env == 'qa' && vars.MONGODB_ATLAS_BASE_URL_QA || vars.MONGODB_ATLAS_BASE_URL }}

.github/workflows/test-suite.yml

@@ -87,7 +87,9 @@ jobs:
       provider_version: ${{ matrix.provider_version }}
       atlas_cloud_env: ${{ inputs.atlas_cloud_env || needs.variables.outputs.is_sun == 'true' && 'qa' || '' }} # Run against QA on Sundays
       use_sa: ${{ needs.variables.outputs.use_sa == 'true' }}
-      send_notification: ${{ inputs.send_notification || false }}
+      # This expression is true if unset (scheduled workflow) and works with boolean and string (GHA params are passed as strings)
+      send_notification: ${{ !contains(github.event.inputs.send_notification, 'false') }}
+
   clean-after:
     needs: tests
     if: ${{ !cancelled() }}