fixed errors

Author: andreaangiolillo

mongodbatlas/fw_resource_mongodbatlas_alert_configuration_test.go

@@ -83,7 +83,6 @@ func TestAccConfigRSAlertConfiguration_EmptyMatcherMetricThresholdConfig(t *test
 					resource.TestCheckResourceAttrSet(resourceName, "project_id"),
 					resource.TestCheckResourceAttr(resourceName, "notification.#", "1"),
 				),
-				ExpectNonEmptyPlan: true,
 			},
 		},
 	})
@@ -899,26 +898,6 @@ resource "mongodbatlas_alert_configuration" "test" {
     email_enabled = false
 	roles         = ["GROUP_OWNER"]
   }
-
-  matcher {
-    field_name = ""
-    operator   = null
-    value      = ""
-  }
-
-  metric_threshold_config {
-    metric_name = ""
-    operator    = null
-    threshold   = null
-    units       = null
-    mode        = ""
-  }
-
-  threshold_config {
-    operator  = null
-    threshold = null
-    units     = null
-  }
 }
 	`, orgID, projectName, enabled)
 }

mongodbatlas/fw_resource_mongodbatlas_project_test.go

@@ -403,7 +403,7 @@ func TestAccProjectRSProject_withInvalidLimitName(t *testing.T) {
 						Value: 1,
 					},
 				}),
-				ExpectError: regexp.MustCompile("Limit not found"),
+				ExpectError: regexp.MustCompile("Not Found"),
 			},
 		},
 	})
@@ -435,7 +435,7 @@ func TestAccProjectRSProject_withInvalidLimitNameOnUpdate(t *testing.T) {
 						Value: 1,
 					},
 				}),
-				ExpectError: regexp.MustCompile("Limit not found"),
+				ExpectError: regexp.MustCompile("Not Found"),
 			},
 		},
 	})

mongodbatlas/resource_mongodbatlas_federated_database_instance_test.go

@@ -57,6 +57,7 @@ func TestAccFederatedDatabaseInstance_basic(t *testing.T) {
 }
 
 func TestAccFederatedDatabaseInstance_S3bucket(t *testing.T) {
+	SkipTestExtCred(t)
 	var (
 		resourceName = "mongodbatlas_federated_database_instance.test"
 		orgID        = os.Getenv("MONGODB_ATLAS_ORG_ID")
@@ -118,9 +119,6 @@ func TestAccFederatedDatabaseInstance_atlasCluster(t *testing.T) {
 					resource.TestCheckResourceAttrSet(resourceName, "storage_stores.0.read_preference.0.tag_sets.#"),
 					resource.TestCheckResourceAttr(resourceName, "storage_stores.0.read_preference.0.tag_sets.#", "2"),
 					resource.TestCheckResourceAttr(resourceName, "storage_stores.0.read_preference.0.tag_sets.0.tags.#", "2"),
-					resource.TestCheckResourceAttrSet(resourceName, "storage_stores.0.read_preference.0.tag_sets.#"),
-					resource.TestCheckResourceAttr(resourceName, "storage_stores.0.read_preference.0.tag_sets.#", "2"),
-					resource.TestCheckResourceAttr(resourceName, "storage_stores.0.read_preference.0.tag_sets.0.tags.#", "2"),
 				),
 			},
 		},
@@ -201,26 +199,6 @@ func testAccMongoDBAtlasFederatedDatabaseInstanceAtlasProviderConfig(projectName
 					value = "app-1"
 				}
 			}
-			tag_sets {
-				tags {
-					name = "environment"
-					value = "development"
-				}
-				tags {
-					name = "application"
-					value = "app"
-				}
-			}
-			tag_sets {
-				tags {
-					name = "environment1"
-					value = "development1"
-				}
-				tags {
-					name = "application1"
-					value = "app-1"
-				}
-			}
 		  }
 		}
 	  
@@ -251,26 +229,6 @@ func testAccMongoDBAtlasFederatedDatabaseInstanceAtlasProviderConfig(projectName
 					value = "app-1"
 				}
 			}
-			tag_sets {
-				tags {
-					name = "environment"
-					value = "development"
-				}
-				tags {
-					name = "application"
-					value = "app"
-				}
-			}
-			tag_sets {
-				tags {
-					name = "environment1"
-					value = "development1"
-				}
-				tags {
-					name = "application1"
-					value = "app-1"
-				}
-			}
 		  }
 		}
 	  }