range int (#2900)

Author: lantoli

internal/common/conversion/model_generation.go

@@ -20,7 +20,7 @@ func CopyModel[T any](src any) (*T, error) {
 	}
 	typeSrc := valSrc.Type()
 	typeDest := valDest.Type()
-	for i := 0; i < typeDest.NumField(); i++ {
+	for i := range typeDest.NumField() {
 		fieldDest := typeDest.Field(i)
 		name := fieldDest.Name
 		{

internal/service/advancedcluster/model_advanced_cluster.go

@@ -417,7 +417,7 @@ func flattenTags(tags *[]admin.ResourceTag) []map[string]string {
 func CheckRegionConfigsPriorityOrder(regionConfigs []admin.ReplicationSpec20240805) error {
 	for _, spec := range regionConfigs {
 		configs := spec.GetRegionConfigs()
-		for i := 0; i < len(configs)-1; i++ {
+		for i := range len(configs) - 1 {
 			if configs[i].GetPriority() < configs[i+1].GetPriority() {
 				return errors.New("priority values in region_configs must be in descending order")
 			}
@@ -430,7 +430,7 @@ func CheckRegionConfigsPriorityOrder(regionConfigs []admin.ReplicationSpec202408
 func CheckRegionConfigsPriorityOrderOld(regionConfigs []admin20240530.ReplicationSpec) error {
 	for _, spec := range regionConfigs {
 		configs := spec.GetRegionConfigs()
-		for i := 0; i < len(configs)-1; i++ {
+		for i := range len(configs) - 1 {
 			if configs[i].GetPriority() < configs[i+1].GetPriority() {
 				return errors.New("priority values in region_configs must be in descending order")
 			}
@@ -603,7 +603,7 @@ func flattenAdvancedReplicationSpecsLogic[T ReplicationSpecSDKModel](
 	tfList := make([]map[string]any, len(apiObjects))
 	wasAPIObjectUsed := make([]bool, len(apiObjects))
 
-	for i := 0; i < len(tfList); i++ {
+	for i := range len(tfList) {
 		var tfMapObject map[string]any
 
 		if len(tfMapObjects) > i {

internal/service/alertconfiguration/data_source_alert_configuration.go

@@ -335,7 +335,7 @@ func outputAlertConfigurationResourceHcl(label string, alert *admin.GroupAlertsC
 	}
 
 	notifications := alert.GetNotifications()
-	for i := 0; i < len(notifications); i++ {
+	for i := range len(notifications) {
 		appendBlockWithCtyValues(resource, "notification", []string{}, convertNotificationToCtyValues(&notifications[i]))
 	}
 

internal/service/alertconfiguration/model_alert_configuration.go

@@ -311,7 +311,7 @@ func NewTFAlertConfigurationDSModelList(alerts []admin.GroupAlertsConfig, projec
 
 	results := make([]TFAlertConfigurationDSModel, len(alerts))
 
-	for i := 0; i < len(alerts); i++ {
+	for i := range len(alerts) {
 		alert := alerts[i]
 		label := fmt.Sprintf("%s_%d", *alert.EventTypeName, i)
 		resultAlertConfigModel := NewTfAlertConfigurationDSModel(&alerts[i], projectID)

internal/service/cloudprovideraccess/resource_cloud_provider_access_authorization.go

@@ -284,7 +284,7 @@ func authorizeRole(ctx context.Context, client *admin.APIClient, d *schema.Resou
 	var role *admin.CloudProviderAccessRole
 	var err error
 
-	for i := 0; i < 3; i++ {
+	for range 3 {
 		role, _, err = client.CloudProviderAccessApi.AuthorizeCloudProviderAccessRole(ctx, projectID, roleID, req).Execute()
 		if err != nil && strings.Contains(err.Error(), "CANNOT_ASSUME_ROLE") { // aws takes time to update , in case of single path
 			log.Printf("warning issue performing authorize: %s \n", err.Error())

internal/service/customdbrole/resource_custom_db_role_test.go

@@ -382,7 +382,7 @@ func TestAccConfigRSCustomDBRoles_MultipleResources(t *testing.T) {
 		orgID = os.Getenv("MONGODB_ATLAS_ORG_ID")
 	)
 
-	for i := 0; i < 5; i++ {
+	for i := range 5 {
 		roleName := fmt.Sprintf("test-acc-custom_role-%d", i)
 		projectName := acc.RandomProjectName()
 		t.Run(roleName, func(t *testing.T) {

internal/service/projectipaccesslist/resource_project_ip_access_list_test.go

@@ -117,7 +117,7 @@ func TestAccProjectIPAccessList_settingMultiple(t *testing.T) {
 		checks           = []resource.TestCheckFunc{}
 	)
 
-	for i := 0; i < ipWhiteListCount; i++ {
+	for i := range ipWhiteListCount {
 		entry := make(map[string]string)
 		entryName := ""
 		ipAddr := ""

internal/service/resourcepolicy/resource_test.go

@@ -163,7 +163,7 @@ func checksResourcePolicy(orgID, name string, policyCount int) resource.TestChec
 	}
 	checks := []resource.TestCheckFunc{checkExists()}
 	checks = acc.AddAttrChecks(dataSourcePluralID, checks, pluralMap)
-	for i := 0; i < policyCount; i++ {
+	for i := range policyCount {
 		checks = acc.AddAttrSetChecks(resourceID, checks, fmt.Sprintf("policies.%d.body", i), fmt.Sprintf("policies.%d.id", i))
 		checks = acc.AddAttrSetChecks(dataSourceID, checks, fmt.Sprintf("policies.%d.body", i), fmt.Sprintf("policies.%d.id", i))
 		checks = acc.AddAttrSetChecks(dataSourcePluralID, checks, fmt.Sprintf("results.0.policies.%d.body", i), fmt.Sprintf("results.0.policies.%d.id", i))

internal/service/team/update_user.go

@@ -77,7 +77,7 @@ func GetChangesForTeamUsers(currentUsers, newUsers []admin.CloudAppUser) (toAdd,
 
 func InitUserSet(users []admin.CloudAppUser) map[string]bool {
 	usersSet := make(map[string]bool, len(users))
-	for i := 0; i < len(users); i++ {
+	for i := range len(users) {
 		usersSet[users[i].GetId()] = true
 	}
 	return usersSet

internal/testutil/unit/http_mocker_round_tripper.go

@@ -138,7 +138,7 @@ func (r *MockRoundTripper) CheckStepRequests(_ *terraform.State) error {
 		missingRequestsCount := len(req.Responses) - r.usedResponses[req.id()]
 		if missingRequestsCount > 0 {
 			missingIndexes := []string{}
-			for i := 0; i < missingRequestsCount; i++ {
+			for i := range missingRequestsCount {
 				missingResponse := (len(req.Responses) - missingRequestsCount) + i
 				missingIndexes = append(missingIndexes, fmt.Sprintf("%d", req.Responses[missingResponse].ResponseIndex))
 			}