INTMDB-919: resource_mongodbatlas_cloud_backup_snapshot_restore_job: Extend guards for delivery type deletions (#1300)

Author: andreaangiolillo

mongodbatlas/resource_mongodbatlas_cloud_backup_snapshot_restore_job.go

@@ -309,7 +309,7 @@ func resourceMongoDBAtlasCloudBackupSnapshotRestoreJobDelete(ctx context.Context
 
 	shouldDelete := true
 
-	// Validate because atomated restore can not be cancelled
+	// Validate because automated restore can not be cancelled
 	if aut, _ := d.Get("delivery_type.automated").(string); aut == "true" {
 		log.Print("Automated restore cannot be cancelled")
 		shouldDelete = false
@@ -320,6 +320,11 @@ func resourceMongoDBAtlasCloudBackupSnapshotRestoreJobDelete(ctx context.Context
 		shouldDelete = false
 	}
 
+	if aut, ok := d.Get("delivery_type_config.0.point_in_time").(bool); ok && aut {
+		log.Print("Point in time restore cannot be cancelled")
+		shouldDelete = false
+	}
+
 	if shouldDelete {
 		_, err := conn.CloudProviderSnapshotRestoreJobs.Delete(context.Background(), requestParameters)
 		if err != nil {

website/docs/r/cloud_backup_snapshot_restore_job.html.markdown

@@ -17,6 +17,9 @@ description: |-
 
 -> **Important:** If you specify `deliveryType` : `automated` or `deliveryType` : `pointInTime` in your request body to create an automated restore job, Atlas removes all existing data on the target cluster prior to the restore.
 
+-> **Important:** If you specify `deliveryType` : `automated` or `deliveryType` : `pointInTime` in your 
+`mongodbatlas_cloud_backup_snapshot_restore_job` resource, you won't be able to delete the snapshot resource in MongoDB Atlas as the Atlas Admin API doesn't support this. The provider will remove the Terraform resource from the state file but won't destroy the MongoDB Atlas resource.
+
 -> **NOTE:** Groups and projects are synonymous terms. You may find `groupId` in the official documentation.
 
 -> **API Key Access List**: This resource requires an Atlas API Access Key List to utilize this feature. This means to manage this resources you must have the IP address or CIDR block that the Terraform connection is coming from added to the Atlas API Key Access List of the Atlas API key you are using. See [Resources that require API Key List](https://www.mongodb.com/docs/atlas/configure-api-access/#use-api-resources-that-require-an-access-list) for details.