chore: Singletons in auto-generated resources (#3458)

* initial auditing_api and maintenance_window_api generation

* fix unmarshal for empty JSON

* improve maintenance_window_api

* checkDestroy in manual resource tests

* explicit version header

* check apiResp is not nil

* support FixedRequestBody

* auditing except delete

* support FixedRequestBody

* comment in MakeApiError

* comment Unmarshal

* use same flow as in SDK

* rename FixedRequestBody to StaticRequestBody

* codegen tests

* revert unneeded test

Author: lantoli

.github/workflows/acceptance-tests-runner.yml

@@ -280,9 +280,11 @@ jobs:
             - 'internal/provider/*.go'
           autogen:
             - 'internal/common/autogen/*.go'
+            - 'internal/serviceapi/auditingapi/*.go'
             - 'internal/serviceapi/clusterapi/*.go'
             - 'internal/serviceapi/customdbroleapi/*.go'
             - 'internal/serviceapi/databaseuserapi/*.go'
+            - 'internal/serviceapi/maintenancewindowapi/*.go'
             - 'internal/serviceapi/projectapi/*.go'
             - 'internal/serviceapi/pushbasedlogexportapi/*.go'
             - 'internal/serviceapi/resourcepolicyapi/*.go'            
@@ -515,9 +517,11 @@ jobs:
           AWS_ACCESS_KEY_ID: ${{ secrets.aws_access_key_id }}
           MONGODB_ATLAS_LAST_VERSION: ${{ needs.get-provider-version.outputs.provider_version }}
           ACCTEST_PACKAGES: |
+            ./internal/serviceapi/auditingapi
             ./internal/serviceapi/clusterapi
             ./internal/serviceapi/customdbroleapi
             ./internal/serviceapi/databaseuserapi
+            ./internal/serviceapi/maintenancewindowapi
             ./internal/serviceapi/projectapi
             ./internal/serviceapi/pushbasedlogexportapi
             ./internal/serviceapi/resourcepolicyapi

internal/common/autogen/handle_operations.go

@@ -145,21 +145,28 @@ func HandleUpdate(ctx context.Context, req HandleUpdateReq) {
 }
 
 type HandleDeleteReq struct {
-	Resp       *resource.DeleteResponse
-	Client     *config.MongoDBClient
-	State      any
-	CallParams *config.APICallParams
-	Wait       *WaitReq
+	Resp              *resource.DeleteResponse
+	Client            *config.MongoDBClient
+	State             any
+	CallParams        *config.APICallParams
+	Wait              *WaitReq
+	StaticRequestBody string
 }
 
 func HandleDelete(ctx context.Context, req HandleDeleteReq) {
 	d := &req.Resp.Diagnostics
-	if _, _, err := callAPIWithoutBody(ctx, req.Client, req.CallParams); err != nil {
+	var err error
+	if req.StaticRequestBody == "" {
+		_, _, err = callAPIWithoutBody(ctx, req.Client, req.CallParams)
+	} else {
+		_, err = callAPIWithBody(ctx, req.Client, req.CallParams, []byte(req.StaticRequestBody))
+	}
+	if err != nil {
 		addError(d, opDelete, errCallingAPI, err)
 		return
 	}
-	if err := handleWaitDelete(ctx, req.Wait, req.Client); err != nil {
-		addError(d, opDelete, errWaitingForChanges, err)
+	if errWait := handleWaitDelete(ctx, req.Wait, req.Client); errWait != nil {
+		addError(d, opDelete, errWaitingForChanges, errWait)
 	}
 }
 

internal/common/autogen/unmarshal.go

@@ -17,6 +17,9 @@ import (
 // Map is not supported yet, will be done in CLOUDP-312797.
 // Attributes that are in JSON but not in the model are ignored, no error is returned.
 func Unmarshal(raw []byte, model any) error {
+	if isEmptyJSON(raw) {
+		return nil // Some operations return an empty response body, in that case there is no need to update the model.
+	}
 	var objJSON map[string]any
 	if err := json.Unmarshal(raw, &objJSON); err != nil {
 		return err

internal/common/autogen/unmarshal_test.go

@@ -433,6 +433,17 @@ func TestUnmarshalZeroLenCollections(t *testing.T) {
 	assert.Equal(t, modelExpected, model)
 }
 
+func TestUnmarshalEmptyJSON(t *testing.T) {
+	model := struct {
+		Attr types.String `tfsdk:"attr"`
+	}{
+		Attr: types.StringValue("hello"),
+	}
+	require.NoError(t, autogen.Unmarshal([]byte(""), &model))
+	require.NoError(t, autogen.Unmarshal(nil, &model))
+	assert.Equal(t, types.StringValue("hello"), model.Attr)
+}
+
 func TestUnmarshalErrors(t *testing.T) {
 	testCases := map[string]struct {
 		model        any

internal/config/client.go

@@ -289,7 +289,11 @@ func (c *MongoDBClient) UntypedAPICall(ctx context.Context, params *APICallParam
 	}
 
 	apiResp, err := untypedClient.CallAPI(apiReq)
+	if err != nil || apiResp == nil {
+		return apiResp, err
+	}
 
+	// Returns a GenericOpenAPIError error if HTTP status code is not successful.
 	if apiResp.StatusCode >= 300 {
 		newErr := untypedClient.MakeApiError(apiResp, params.Method, localVarPath)
 		return apiResp, newErr

internal/service/maintenancewindow/resource_maintenance_window_test.go

@@ -42,6 +42,7 @@ func TestAccConfigRSMaintenanceWindow_basic(t *testing.T) {
 	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:                 func() { acc.PreCheckBasic(t) },
 		ProtoV6ProviderFactories: acc.TestAccProviderV6Factories,
+		CheckDestroy:             checkDestroy,
 		Steps: []resource.TestStep{
 			{
 				// testing hour_of_day set to 0 during creation phase does not return errors
@@ -80,6 +81,7 @@ func TestAccConfigRSMaintenanceWindow_emptyHourOfDay(t *testing.T) {
 	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:                 func() { acc.PreCheckBasic(t) },
 		ProtoV6ProviderFactories: acc.TestAccProviderV6Factories,
+		CheckDestroy:             checkDestroy,
 		Steps: []resource.TestStep{
 			{
 				Config: configBasic(orgID, projectName, dayOfWeek, nil, defaultProtectedHours),
@@ -100,6 +102,7 @@ func TestAccConfigRSMaintenanceWindow_autoDeferActivated(t *testing.T) {
 	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:                 func() { acc.PreCheckBasic(t) },
 		ProtoV6ProviderFactories: acc.TestAccProviderV6Factories,
+		CheckDestroy:             checkDestroy,
 		Steps: []resource.TestStep{
 			{
 				Config: configWithAutoDeferEnabled(orgID, projectName, dayOfWeek, hourOfDay),
@@ -135,6 +138,24 @@ func checkExists(resourceName string) resource.TestCheckFunc {
 	}
 }
 
+func checkDestroy(s *terraform.State) error {
+	for _, rs := range s.RootModule().Resources {
+		if rs.Type != "mongodbatlas_maintenance_window" {
+			continue
+		}
+		projectID := rs.Primary.ID
+		if projectID == "" {
+			return fmt.Errorf("checkDestroy, no ID is set for: %s", resourceName)
+		}
+		maintenanceWindow, _, _ := acc.ConnV2().MaintenanceWindowsApi.GetMaintenanceWindow(context.Background(), projectID).Execute()
+		// Check if it's back to default settings (day_of_week = 0 means it's been reset)
+		if maintenanceWindow.GetDayOfWeek() != 0 {
+			return fmt.Errorf("maintenance window for project (%s) was not properly reset to defaults", projectID)
+		}
+	}
+	return nil
+}
+
 func importStateIDFunc(resourceName string) resource.ImportStateIdFunc {
 	return func(s *terraform.State) (string, error) {
 		rs, ok := s.RootModule().Resources[resourceName]

internal/serviceapi/auditingapi/main_test.go

@@ -0,0 +1,15 @@
+package auditingapi_test
+
+import (
+	"os"
+	"testing"
+
+	"github.com/mongodb/terraform-provider-mongodbatlas/internal/testutil/acc"
+)
+
+func TestMain(m *testing.M) {
+	cleanup := acc.SetupSharedResources()
+	exitCode := m.Run()
+	cleanup()
+	os.Exit(exitCode)
+}