fix: added validation for autoscaling compute enabled and when true add the parameter autoscaling to request and its test

Author: Edgar López

mongodbatlas/resource_mongodbatlas_cluster.go

@@ -1025,14 +1025,15 @@ func getInstanceSizeToInt(instanceSize string) int {
 
 func expandProviderSetting(d *schema.ResourceData) (*matlas.ProviderSettings, error) {
 	var (
-		region, _       = valRegion(d.Get("provider_region_name"))
-		minInstanceSize = getInstanceSizeToInt(d.Get("provider_auto_scaling_compute_min_instance_size").(string))
-		maxInstanceSize = getInstanceSizeToInt(d.Get("provider_auto_scaling_compute_max_instance_size").(string))
-		instanceSize    = getInstanceSizeToInt(d.Get("provider_instance_size_name").(string))
-		compute         *matlas.Compute
+		region, _          = valRegion(d.Get("provider_region_name"))
+		minInstanceSize    = getInstanceSizeToInt(d.Get("provider_auto_scaling_compute_min_instance_size").(string))
+		maxInstanceSize    = getInstanceSizeToInt(d.Get("provider_auto_scaling_compute_max_instance_size").(string))
+		instanceSize       = getInstanceSizeToInt(d.Get("provider_instance_size_name").(string))
+		compute            *matlas.Compute
+		autoScalingEnabled = d.Get("auto_scaling_compute_enabled").(bool)
 	)
 
-	if minInstanceSize != 0 {
+	if minInstanceSize != 0 && autoScalingEnabled {
 		if instanceSize < minInstanceSize {
 			return nil, fmt.Errorf("`provider_auto_scaling_compute_min_instance_size` must be lower than `provider_instance_size_name`")
 		}
@@ -1042,7 +1043,7 @@ func expandProviderSetting(d *schema.ResourceData) (*matlas.ProviderSettings, er
 		}
 	}
 
-	if maxInstanceSize != 0 {
+	if maxInstanceSize != 0 && autoScalingEnabled {
 		if instanceSize > maxInstanceSize {
 			return nil, fmt.Errorf("`provider_auto_scaling_compute_max_instance_size` must be higher than `provider_instance_size_name`")
 		}
@@ -1060,7 +1061,10 @@ func expandProviderSetting(d *schema.ResourceData) (*matlas.ProviderSettings, er
 		RegionName:          region,
 		VolumeType:          cast.ToString(d.Get("provider_volume_type")),
 		DiskTypeName:        cast.ToString(d.Get("provider_disk_type_name")),
-		AutoScaling:         &matlas.AutoScaling{Compute: compute},
+	}
+
+	if autoScalingEnabled {
+		providerSettings.AutoScaling = &matlas.AutoScaling{Compute: compute}
 	}
 
 	if d.Get("provider_name") == "AWS" {

mongodbatlas/resource_mongodbatlas_cluster_test.go

@@ -797,7 +797,7 @@ func TestAccResourceMongoDBAtlasCluster_tenant(t *testing.T) {
 		CheckDestroy: testAccCheckMongoDBAtlasClusterDestroy,
 		Steps: []resource.TestStep{
 			{
-				Config: testAccMongoDBAtlasClusterConfigTenant(projectID, name, "M2"),
+				Config: testAccMongoDBAtlasClusterConfigTenant(projectID, name, "M2", "2"),
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckMongoDBAtlasClusterExists(resourceName, &cluster),
 					testAccCheckMongoDBAtlasClusterAttributes(&cluster, name),
@@ -834,7 +834,7 @@ func TestAccResourceMongoDBAtlasCluster_tenant_m5(t *testing.T) {
 		CheckDestroy: testAccCheckMongoDBAtlasClusterDestroy,
 		Steps: []resource.TestStep{
 			{
-				Config: testAccMongoDBAtlasClusterConfigTenant(projectID, name, "M5"),
+				Config: testAccMongoDBAtlasClusterConfigTenant(projectID, name, "M5", "5"),
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckMongoDBAtlasClusterExists(resourceName, &cluster),
 					testAccCheckMongoDBAtlasClusterAttributes(&cluster, name),
@@ -1140,20 +1140,24 @@ func testAccMongoDBAtlasClusterConfigGlobal(projectID, name, backupEnabled strin
 	`, projectID, name, backupEnabled)
 }
 
-func testAccMongoDBAtlasClusterConfigTenant(projectID, name, instanceSize string) string {
+func testAccMongoDBAtlasClusterConfigTenant(projectID, name, instanceSize, diskSize string) string {
 	return fmt.Sprintf(`
 	resource "mongodbatlas_cluster" "tenant" {
 		project_id = "%s"
 		name       = "%s"
 
 		provider_name         = "TENANT"
 		backing_provider_name = "AWS"
-		provider_region_name  = "EU_CENTRAL_1"
+		provider_region_name  = "US_EAST_1"
+	  	//M2 must be 2, M5 must be 5
+	  	disk_size_gb            = "%s"
 
 		provider_instance_size_name  = "%s"
+		//These must be the following values
+ 	 	mongo_db_major_version = "4.2"
 		auto_scaling_disk_gb_enabled = false
 	  }
-	`, projectID, name, instanceSize)
+	`, projectID, name, diskSize, instanceSize)
 }
 
 func testAccMongoDBAtlasClusterConfigTenantUpdated(projectID, name string) string {