fixes failing snapshots because timeout is too short (#583)

* fixes failing snapshots because timeout is too short

* uses default timeout from Default field

* improves documentation of the duration field

* fixes failing tests

Author: ebostijancic

mongodbatlas/resource_mongodbatlas_cloud_provider_snapshot.go

@@ -79,6 +79,12 @@ func resourceMongoDBAtlasCloudProviderSnapshot() *schema.Resource {
 				Type:     schema.TypeString,
 				Computed: true,
 			},
+			"timeout": {
+				Type:     schema.TypeString,
+				Optional: true,
+				ForceNew: true,
+				Default:  "10m",
+			},
 		},
 		DeprecationMessage: "this resource is deprecated, please transition as soon as possible to mongodbatlas_cloud_backup_snapshot",
 	}
@@ -158,17 +164,24 @@ func resourceMongoDBAtlasCloudProviderSnapshotCreate(ctx context.Context, d *sch
 		RetentionInDays: d.Get("retention_in_days").(int),
 	}
 
+	var timeout time.Duration
+
+	timeout, err := time.ParseDuration(d.Get("timeout").(string))
+	if err != nil {
+		return diag.FromErr(err)
+	}
+
 	stateConf := &resource.StateChangeConf{
 		Pending:    []string{"CREATING", "UPDATING", "REPAIRING", "REPEATING"},
 		Target:     []string{"IDLE"},
 		Refresh:    resourceClusterRefreshFunc(ctx, d.Get("cluster_name").(string), d.Get("project_id").(string), conn),
-		Timeout:    10 * time.Minute,
+		Timeout:    timeout,
 		MinTimeout: 10 * time.Second,
 		Delay:      3 * time.Minute,
 	}
 
 	// Wait, catching any errors
-	_, err := stateConf.WaitForStateContext(ctx)
+	_, err = stateConf.WaitForStateContext(ctx)
 	if err != nil {
 		return diag.FromErr(err)
 	}

website/docs/r/cloud_provider_snapshot.html.markdown

@@ -35,6 +35,7 @@ On-demand snapshots happen immediately, unlike scheduled snapshots which occur a
     cluster_name      = mongodbatlas_cluster.my_cluster.name
     description       = "myDescription"
     retention_in_days = 1
+    timeout           = "10m"
   }
   
   resource "mongodbatlas_cloud_provider_snapshot_restore_job" "test" {
@@ -53,6 +54,7 @@ On-demand snapshots happen immediately, unlike scheduled snapshots which occur a
 * `cluster_name` - (Required) The name of the Atlas cluster that contains the snapshots you want to retrieve.
 * `description` - (Required) Description of the on-demand snapshot.
 * `retention_in_days` - (Required) The number of days that Atlas should retain the on-demand snapshot. Must be at least 1.
+* `timeout`- (Optional) The duration of time to wait to finish the on-demand snapshot. The timeout value is definded by a signed sequence of decimal numbers with an time unit suffix such as: `1h45m`, `300s`, `10m`, .... The valid time units are:  `ns`, `us` (or `µs`), `ms`, `s`, `m`, `h`. Default value for the timeout is `10m`
 
 ## Attributes Reference