fix: Supporting advanced_cluster upgrade to dedicated with NMVe instance (#3725)

* supporting advanced_cluster tenant and flex upgrade to NMVe instance

* adjusting mock files

* Update .changelog/3725.txt

Co-authored-by: Leo Antoli <[email protected]>

---------

Co-authored-by: Leo Antoli <[email protected]>

Author: AgustinBettati

.changelog/3725.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/mongodbatlas_advanced_cluster: Allows upgrade from tenant and flex cluster to dedicated NVMe with backup enabled
+```

internal/service/advancedcluster/resource_test.go

@@ -64,8 +64,8 @@ func testAccAdvancedClusterFlexUpgrade(t *testing.T, projectID, clusterName, ins
 	}
 	if includeDedicated {
 		steps = append(steps, resource.TestStep{
-			Config: acc.ConfigBasicDedicated(projectID, clusterName, defaultZoneName),
-			Check:  checksBasicDedicated(projectID, clusterName, false),
+			Config: acc.ConfigDedicatedNVMeBackupEnabled(projectID, clusterName, defaultZoneName),
+			Check:  checksDedicatedNVMeBackupEnabled(projectID, clusterName, false),
 		})
 	}
 
@@ -102,8 +102,8 @@ func TestAccMockableAdvancedCluster_tenantUpgrade(t *testing.T) {
 				Check:  checkTenant(projectID, clusterName, true),
 			},
 			{
-				Config: acc.ConfigBasicDedicated(projectID, clusterName, defaultZoneName),
-				Check:  checksBasicDedicated(projectID, clusterName, true),
+				Config: acc.ConfigDedicatedNVMeBackupEnabled(projectID, clusterName, defaultZoneName),
+				Check:  checksDedicatedNVMeBackupEnabled(projectID, clusterName, true),
 			},
 			acc.TestStepImportCluster(resourceName),
 		},
@@ -1437,12 +1437,14 @@ func checkTenant(projectID, name string, checkPlural bool) resource.TestCheckFun
 		pluralChecks...)
 }
 
-func checksBasicDedicated(projectID, name string, checkPlural bool) resource.TestCheckFunc {
+func checksDedicatedNVMeBackupEnabled(projectID, name string, checkPlural bool) resource.TestCheckFunc {
 	originalChecks := checkTenant(projectID, name, checkPlural)
 	checkMap := map[string]string{
-		"replication_specs.0.region_configs.0.electable_specs.node_count":    "3",
-		"replication_specs.0.region_configs.0.electable_specs.instance_size": "M10",
-		"replication_specs.0.region_configs.0.provider_name":                 "AWS",
+		"backup_enabled": "true",
+		"replication_specs.0.region_configs.0.electable_specs.node_count":      "3",
+		"replication_specs.0.region_configs.0.electable_specs.instance_size":   "M40_NVME",
+		"replication_specs.0.region_configs.0.electable_specs.ebs_volume_type": "PROVISIONED",
+		"replication_specs.0.region_configs.0.provider_name":                   "AWS",
 	}
 	return checkAggr(nil, checkMap, originalChecks)
 }

internal/service/advancedcluster/resource_upgrade.go

@@ -2,6 +2,7 @@ package advancedcluster
 
 import (
 	"github.com/mongodb/terraform-provider-mongodbatlas/internal/common/constant"
+	"github.com/mongodb/terraform-provider-mongodbatlas/internal/common/conversion"
 	"github.com/mongodb/terraform-provider-mongodbatlas/internal/service/flexcluster"
 	"go.mongodb.org/atlas-sdk/v20250312007/admin"
 )
@@ -17,14 +18,19 @@ func getUpgradeTenantRequest(state, patch *admin.ClusterDescription20240805) *ad
 	if oldProviderName != constant.TENANT || newProviderName == constant.TENANT {
 		return nil
 	}
-	return &admin.LegacyAtlasTenantClusterUpgradeRequest{
+	req := admin.LegacyAtlasTenantClusterUpgradeRequest{
 		Name: state.GetName(),
 		ProviderSettings: &admin.ClusterProviderSettings{
 			ProviderName:     newProviderName,
 			RegionName:       newRegion.RegionName,
 			InstanceSizeName: newRegion.GetElectableSpecs().InstanceSize,
 		},
 	}
+	if patch.GetBackupEnabled() {
+		// ProviderBackupEnabled must be used instead of BackupEnabled for tenant upgrade request, details in CLOUDP-327109
+		req.ProviderBackupEnabled = conversion.Pointer(true)
+	}
+	return &req
 }
 
 func getUpgradeFlexToDedicatedRequest(state, patch *admin.ClusterDescription20240805) *admin.AtlasTenantClusterUpgradeRequest20240805 {
@@ -40,9 +46,15 @@ func getUpgradeFlexToDedicatedRequest(state, patch *admin.ClusterDescription2024
 	if oldProviderName != flexcluster.FlexClusterType || newProviderName == flexcluster.FlexClusterType {
 		return nil
 	}
-	return &admin.AtlasTenantClusterUpgradeRequest20240805{
+	req := admin.AtlasTenantClusterUpgradeRequest20240805{
 		Name:             state.GetName(),
 		ClusterType:      state.ClusterType,
 		ReplicationSpecs: patch.ReplicationSpecs,
 	}
+
+	// checking for state value as a flex cluster can already have backup enabled
+	if state.GetBackupEnabled() || patch.GetBackupEnabled() {
+		req.BackupEnabled = conversion.Pointer(true)
+	}
+	return &req
 }