chore: Deprecate id in plural data sources (#3476)

* deprecate id in plural data sources

* changelog

* fix changelog

* remove projects from changelog

* update changelog text

Author: lantoli

.changelog/3476.txt

@@ -0,0 +1,7 @@
+```release-note:note
+data-source/mongodbatlas_stream_connections: Deprecates the `id` attribute as it is a random assigned value which should not be used
+```
+
+```release-note:note
+data-source/mongodbatlas_stream_instances: Deprecates the `id` attribute as it is a random assigned value which should not be used
+```

docs/data-sources/projects.md

@@ -41,7 +41,7 @@ data "mongodbatlas_projects" "test" {
 * `items_per_page` - (Optional) Number of items to return per page, up to a maximum of 500. Defaults to `100`.
 
 
-* `id` - Autogenerated Unique ID for this data source.
+* `id` - (Deprecated) Autogenerated Unique ID for this data source.
 * `total_count` - Represents the total of the projects
 
 * `results` - A list where each represents a Projects.

internal/common/conversion/schema_generation.go

@@ -7,6 +7,7 @@ import (
 
 	dsschema "github.com/hashicorp/terraform-plugin-framework/datasource/schema"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema"
+	"github.com/mongodb/terraform-provider-mongodbatlas/internal/common/constant"
 )
 
 type DataSourceSchemaRequest struct {
@@ -54,7 +55,7 @@ func PluralDataSourceSchemaFromResource(rs schema.Schema, req *PluralDataSourceS
 		MarkdownDescription: resultsDoc,
 	}
 	if req.HasLegacyFields {
-		rootAttrs["id"] = dsschema.StringAttribute{Computed: true}
+		rootAttrs["id"] = dsschema.StringAttribute{Computed: true, DeprecationMessage: constant.DeprecationParam}
 		rootAttrs["total_count"] = dsschema.Int64Attribute{Computed: true}
 		rootAttrs["page_num"] = dsschema.Int64Attribute{Optional: true}
 		rootAttrs["items_per_page"] = dsschema.Int64Attribute{Optional: true}

internal/common/conversion/schema_generation_test.go

@@ -10,6 +10,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema"
 	"github.com/hashicorp/terraform-plugin-framework/schema/validator"
 	"github.com/hashicorp/terraform-plugin-framework/types"
+	"github.com/mongodb/terraform-provider-mongodbatlas/internal/common/constant"
 	"github.com/mongodb/terraform-provider-mongodbatlas/internal/common/conversion"
 	"github.com/stretchr/testify/assert"
 )
@@ -568,7 +569,8 @@ func TestPluralDataSourceSchemaFromResource_legacyFields(t *testing.T) {
 				Description:         "desc requiredAttrString",
 			},
 			"id": dsschema.StringAttribute{
-				Computed: true,
+				Computed:           true,
+				DeprecationMessage: constant.DeprecationParam,
 			},
 			"page_num": dsschema.Int64Attribute{
 				Optional: true,