test: Migration tests for all SDKv2 and TPF paths (#3194)

* migTest and env var MONGODB_ATLAS_TEST_SDKV2_TO_TPF

* refactor IsTestSDKv2ToTPF

* add MONGODB_ATLAS_LAST_VERSION

* keep HTTP_MOCKER_CAPTURE

* keep HTTP_MOCKER_CAPTURE

* make sure TPF is enabled in setupTestsSDKv2ToTPF

* Update internal/testutil/acc/shared_resource.go

Co-authored-by: Espen Albert <[email protected]>

---------

Co-authored-by: Espen Albert <[email protected]>

Author: lantoli

.github/workflows/acceptance-tests-runner.yml

@@ -412,14 +412,40 @@ jobs:
         run: make testmact
       - name: Acceptance Tests
         env:
-          MONGODB_ATLAS_LAST_VERSION: '1.28.0' # Fix mig test version until CLOUDP-296406 is resolved
+          MONGODB_ATLAS_LAST_VERSION: ${{ needs.get-provider-version.outputs.provider_version }}
           HTTP_MOCKER_CAPTURE: 'true'
           ACCTEST_REGEX_RUN: ${{ inputs.reduced_tests && '^TestAccMockable' || env.ACCTEST_REGEX_RUN }}
           ACCTEST_PACKAGES: |
             ./internal/service/advancedcluster
             ./internal/service/advancedclustertpf
         run: make testacc
 
+  advanced_cluster_tpf_mig_from_sdkv2:
+    needs: [ change-detection, get-provider-version ]
+    if: ${{ inputs.reduced_tests == false && (needs.change-detection.outputs.advanced_cluster_tpf == 'true' || inputs.test_group == 'advanced_cluster_tpf') }}
+    env:
+      MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER: 'true'
+      MONGODB_ATLAS_TEST_SDKV2_TO_TPF: 'true'
+    runs-on: ubuntu-latest
+    permissions: {}
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
+        with:
+          ref: ${{ inputs.ref || github.ref }}
+      - uses: actions/setup-go@f111f3307d8850f501ac008e886eec1fd1932a34
+        with:
+          go-version-file: 'go.mod'
+      - uses: hashicorp/setup-terraform@b9cd54a3c349d3f38e8881555d616ced269862dd
+        with:
+          terraform_version: ${{ inputs.terraform_version }}
+          terraform_wrapper: false  
+      - name: Acceptance Tests
+        env:
+          MONGODB_ATLAS_LAST_VERSION: ${{ needs.get-provider-version.outputs.provider_version }}
+          ACCTEST_REGEX_RUN: '^TestMig'
+          ACCTEST_PACKAGES: ./internal/service/advancedcluster
+        run: make testacc
+
   assume_role:
     needs: [ change-detection, get-provider-version ]
     if: ${{ needs.change-detection.outputs.assume_role == 'true' || inputs.test_group == 'assume_role' }}

internal/service/advancedcluster/resource_advanced_cluster_migration_test.go

@@ -6,6 +6,7 @@ import (
 
 	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
 
+	"github.com/mongodb/terraform-provider-mongodbatlas/internal/config"
 	"github.com/mongodb/terraform-provider-mongodbatlas/internal/testutil/acc"
 	"github.com/mongodb/terraform-provider-mongodbatlas/internal/testutil/mig"
 )
@@ -14,29 +15,24 @@ import (
 const versionBeforeISSRelease = "1.17.6"
 
 func TestMigAdvancedCluster_replicaSetAWSProvider(t *testing.T) {
-	testCase := replicaSetAWSProviderTestCase(t, false)
-	mig.CreateAndRunTest(t, &testCase)
+	migTest(t, replicaSetAWSProviderTestCase)
 }
 
 func TestMigAdvancedCluster_replicaSetMultiCloud(t *testing.T) {
-	testCase := replicaSetMultiCloudTestCase(t, false)
-	mig.CreateAndRunTest(t, &testCase)
+	migTest(t, replicaSetMultiCloudTestCase)
 }
 
 func TestMigAdvancedCluster_singleShardedMultiCloud(t *testing.T) {
-	testCase := singleShardedMultiCloudTestCase(t, false)
-	mig.CreateAndRunTest(t, &testCase)
+	migTest(t, singleShardedMultiCloudTestCase)
 }
 
 func TestMigAdvancedCluster_symmetricGeoShardedOldSchema(t *testing.T) {
-	testCase := symmetricGeoShardedOldSchemaTestCase(t, false)
-	mig.CreateAndRunTest(t, &testCase)
+	migTest(t, symmetricGeoShardedOldSchemaTestCase)
 }
 
 func TestMigAdvancedCluster_asymmetricShardedNewSchema(t *testing.T) {
 	mig.SkipIfVersionBelow(t, "1.23.0") // version where sharded cluster tier auto-scaling was introduced
-	testCase := asymmetricShardedNewSchemaTestCase(t, false)
-	mig.CreateAndRunTest(t, &testCase)
+	migTest(t, asymmetricShardedNewSchemaTestCase)
 }
 
 func TestMigAdvancedCluster_replicaSetAWSProviderUpdate(t *testing.T) {
@@ -282,3 +278,15 @@ func configPartialAdvancedConfig(projectID, clusterName, extraArgs, autoScaling
 		}
 	`, projectID, clusterName, extraArgs, autoScaling)
 }
+
+// migTest is a helper function to run migration tests in normal case (SDKv2 -> SDKv2, TPF -> TPF), or in mixed case (SDKv2 -> TPF).
+func migTest(t *testing.T, testCaseFunc func(t *testing.T, isAcc bool) resource.TestCase) {
+	t.Helper()
+	isAcc := config.PreviewProviderV2AdvancedCluster()
+	if acc.IsTestSDKv2ToTPF() {
+		isAcc = false
+		t.Log("Running test SDKv2 to TPF")
+	}
+	testCase := testCaseFunc(t, isAcc)
+	mig.CreateAndRunTest(t, &testCase)
+}

internal/testutil/acc/advanced_cluster_preview_provider_v2.go

@@ -1,6 +1,8 @@
 package acc
 
 import (
+	"os"
+	"strconv"
 	"strings"
 	"testing"
 
@@ -14,6 +16,12 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
+// IsTestSDKv2ToTPF returns if we want to run migration tests from SDKv2 to TPF.
+func IsTestSDKv2ToTPF() bool {
+	env, _ := strconv.ParseBool(os.Getenv("MONGODB_ATLAS_TEST_SDKV2_TO_TPF"))
+	return env
+}
+
 func CheckRSAndDSPreviewProviderV2(isAcc bool, resourceName string, dataSourceName, pluralDataSourceName *string, attrsSet []string, attrsMap map[string]string, extra ...resource.TestCheckFunc) resource.TestCheckFunc {
 	modifiedSet := ConvertToPreviewProviderV2AttrsSet(isAcc, attrsSet)
 	modifiedMap := ConvertToPreviewProviderV2AttrsMap(isAcc, attrsMap)

internal/testutil/acc/shared_resource.go

@@ -2,10 +2,12 @@ package acc
 
 import (
 	"fmt"
+	"os"
 	"sync"
 	"testing"
 	"time"
 
+	"github.com/mongodb/terraform-provider-mongodbatlas/internal/config"
 	"github.com/stretchr/testify/require"
 )
 
@@ -17,6 +19,7 @@ const (
 // It returns the cleanup function that must be called at the end of TestMain.
 func SetupSharedResources() func() {
 	sharedInfo.init = true
+	setupTestsSDKv2ToTPF()
 	return cleanupSharedResources
 }
 
@@ -166,3 +169,11 @@ func NextProjectIDClusterName(totalNodeCount int, projectCreator func(string) st
 	}
 	return project.id, RandomClusterName()
 }
+
+// setupTestsSDKv2ToTPF sets the Preview environment variable to false so the previous version in migration tests uses SDKv2.
+// However the current version will use TPF as the variable is only read once during import when it was true.
+func setupTestsSDKv2ToTPF() {
+	if IsTestSDKv2ToTPF() && config.PreviewProviderV2AdvancedCluster() {
+		os.Setenv(config.PreviewProviderV2AdvancedClusterEnvVar, "false")
+	}
+}