chore: Remove SDKv2 advanced_cluster resource (#3694)

Author: lantoli

.golangci.yml

@@ -32,6 +32,7 @@ linters:
     - unused
     - usetesting
     - whitespace
+    - usestdlibvars
 
   settings:
     funlen:

internal/common/constant/deprecation.go

@@ -3,11 +3,6 @@ package constant
 const (
 	DeprecationParam                            = "This parameter is deprecated."
 	DeprecationParamWithReplacement             = "This parameter is deprecated. Please transition to %s."
-	DeprecationParamByVersion                   = "This parameter is deprecated and will be removed in version %s."
-	DeprecationParamByVersionWithReplacement    = "This parameter is deprecated and will be removed in version %s. Please transition to %s."
-	DeprecationParamFutureWithReplacement       = "This parameter is deprecated and will be removed in the future. Please transition to %s"
-	DeprecationResourceByDateWithReplacement    = "This resource is deprecated and will be removed in %s. Please transition to %s."
-	DeprecationDataSourceByDateWithReplacement  = "This data source is deprecated and will be removed in %s. Please transition to %s."
 	DeprecationResourceByDateWithExternalLink   = "This resource is deprecated and will be removed in %s. For more details see %s."
 	DeprecationDataSourceByDateWithExternalLink = "This data source is deprecated and will be removed in %s. For more details see %s."
 	DeprecationParamByDateWithExternalLink      = "This parameter is deprecated and will be removed in %s. For more details see %s."

internal/common/validate/cluster_error_checks.go

@@ -34,15 +34,15 @@ func TestNetworkLoggingTransport_Success(t *testing.T) {
 	log.SetOutput(&logOutput)
 	defer log.SetOutput(os.Stderr)
 	mockResp := &http.Response{
-		StatusCode: 200,
+		StatusCode: http.StatusOK,
 		Header:     make(http.Header),
 	}
 	mockTransport := &mockTransport{
 		response: mockResp,
 		err:      nil,
 	}
 	transport := config.NewTransportWithNetworkLogging(mockTransport, true)
-	req := httptest.NewRequest("GET", "https://api.example.com/test", http.NoBody)
+	req := httptest.NewRequest(http.MethodGet, "https://api.example.com/test", http.NoBody)
 	resp, err := transport.RoundTrip(req)
 	require.NoError(t, err)
 	require.Equal(t, 200, resp.StatusCode)
@@ -58,18 +58,18 @@ func TestNetworkLoggingTransport_HTTPError(t *testing.T) {
 	log.SetOutput(&logOutput)
 	defer log.SetOutput(os.Stderr)
 	mockResp := &http.Response{
-		StatusCode: 500,
+		StatusCode: http.StatusInternalServerError,
 		Header:     make(http.Header),
 	}
 	mockTransport := &mockTransport{
 		response: mockResp,
 		err:      nil,
 	}
 	transport := config.NewTransportWithNetworkLogging(mockTransport, true)
-	req := httptest.NewRequest("POST", "https://api.example.com/test", http.NoBody)
+	req := httptest.NewRequest(http.MethodPost, "https://api.example.com/test", http.NoBody)
 	resp, err := transport.RoundTrip(req)
 	require.NoError(t, err)
-	require.Equal(t, 500, resp.StatusCode)
+	require.Equal(t, http.StatusInternalServerError, resp.StatusCode)
 
 	logStr := logOutput.String()
 	assert.Contains(t, logStr, "Network Request Start")
@@ -88,7 +88,7 @@ func TestNetworkLoggingTransport_NetworkError(t *testing.T) {
 		err:      networkErr,
 	}
 	transport := config.NewTransportWithNetworkLogging(mockTransport, true)
-	req := httptest.NewRequest("GET", "https://api.example.com/test", http.NoBody)
+	req := httptest.NewRequest(http.MethodGet, "https://api.example.com/test", http.NoBody)
 	resp, err := transport.RoundTrip(req)
 	require.Error(t, err)
 	require.Equal(t, networkErr, err)
@@ -105,7 +105,7 @@ func TestNetworkLoggingTransport_DigestAuthChallenge(t *testing.T) {
 	log.SetOutput(&logOutput)
 	defer log.SetOutput(os.Stderr)
 	mockResp := &http.Response{
-		StatusCode: 401,
+		StatusCode: http.StatusUnauthorized,
 		Header:     make(http.Header),
 	}
 	mockResp.Header.Set("WWW-Authenticate", "Digest realm=\"MongoDB Atlas\", nonce=\"abc123\"")
@@ -114,7 +114,7 @@ func TestNetworkLoggingTransport_DigestAuthChallenge(t *testing.T) {
 		err:      nil,
 	}
 	transport := config.NewTransportWithNetworkLogging(mockTransport, true)
-	req := httptest.NewRequest("GET", "https://cloud.mongodb.com/api/atlas/v2/groups", http.NoBody)
+	req := httptest.NewRequest(http.MethodGet, "https://cloud.mongodb.com/api/atlas/v2/groups", http.NoBody)
 	resp, err := transport.RoundTrip(req)
 	require.NoError(t, err)
 	require.Equal(t, 401, resp.StatusCode)
@@ -134,18 +134,18 @@ func TestNetworkLoggingTransport_Disabled(t *testing.T) {
 	log.SetOutput(&logOutput)
 	defer log.SetOutput(os.Stderr)
 	mockResp := &http.Response{
-		StatusCode: 200,
+		StatusCode: http.StatusOK,
 		Header:     make(http.Header),
 	}
 	mockTransport := &mockTransport{
 		response: mockResp,
 		err:      nil,
 	}
 	transport := config.NewTransportWithNetworkLogging(mockTransport, false)
-	req := httptest.NewRequest("GET", "https://api.example.com/test", http.NoBody)
+	req := httptest.NewRequest(http.MethodGet, "https://api.example.com/test", http.NoBody)
 	resp, err := transport.RoundTrip(req)
 	require.NoError(t, err)
-	require.Equal(t, 200, resp.StatusCode)
+	require.Equal(t, http.StatusOK, resp.StatusCode)
 
 	logStr := logOutput.String()
 	assert.Empty(t, logStr, "Expected no logs when network logging is disabled")