chore: Supports running Test Suite in QA on sundays (#2711)

* Revert "chore: Use `qa` for TestSuite on Sundays (#2701)"

This reverts commit 942e097.

* chore: Supports running qa only on Sundays

* address PR comments

* refactor: move job to steps of variables

* chore: Add top level description

Author: EspenAlbert

.github/workflows/terraform-compatibility-matrix.yml

@@ -47,7 +47,7 @@ jobs:
     uses: ./.github/workflows/test-suite.yml
     with:
       terraform_matrix: '["${{ matrix.terraform_version }}"]'
-      atlas_cloud_env: ${{ inputs.atlas_cloud_env }}
+      atlas_cloud_env: ${{ inputs.atlas_cloud_env || 'dev' }}
       send_notification: false
 
   slack-notification:

.github/workflows/test-suite.yml

@@ -1,6 +1,8 @@
 name: 'Test Suite'
 
-# Runs acceptance and migrations tests with a set of terraform versions and provider versions (used for migration tests). This worflow is scheduled daily except Saturdays, but can also be run manually.
+# Runs acceptance and migrations tests with a set of terraform versions and provider versions (used for migration tests). 
+# This worflow is scheduled daily and runs against dev every day except for Sunday when we run against QA. It can also be run manually.
+# The 1st day of the month we run terraform-compatibility-matrix.yml and therefore, we skip the test-suite (see shedule->cron below).
 on:
   workflow_dispatch:
     inputs:
@@ -33,47 +35,47 @@ on:
         default: true
 
   schedule:
-    # https://crontab.guru/#0_0_2-31_*_0
-    - cron: "0 0 2-31 * 1-6" # workflow runs at 00:00 on every day-of-month from 2 through 31 and on every day-of-week from Monday through Saturday.
-    - cron: "0 0 2-31 * 0" # workflow runs at 00:00 on every day-of-month from 2 through 31 and on Sunday.
-   
+    - cron: "0 0 2-31 * *" # workflow runs every day at midnight UTC except on the first day of the month
 concurrency:
   group: '${{ github.workflow }}'
   cancel-in-progress: false
 
 jobs:
-  versions:
+  variables:
     env:
       schedule_terraform_matrix: '["${{ vars.TF_VERSION_LATEST }}"]'
       schedule_provider_matrix: '[""]' # "" for latest version    
     runs-on: ubuntu-latest
     outputs:
       terraform_matrix: ${{ inputs.terraform_matrix || env.schedule_terraform_matrix }}
       provider_matrix: ${{ inputs.provider_matrix || env.schedule_provider_matrix }}
+      day: ${{ steps.set_day.outputs.DAY }}
     steps:
-      - if: false
-        run: echo jobs need steps
-
+      - name: set day
+        id: set_day
+        run: |
+          echo "DAY=$(date +'%a')"
+          echo "DAY=$(date +'%a')" >> "$GITHUB_OUTPUT"
   clean-before:
     secrets: inherit
     uses: ./.github/workflows/cleanup-test-env.yml
 
   tests:
-    needs: [clean-before, versions]
+    needs: [clean-before, variables]
     if: ${{ !cancelled() }}
     strategy:
       max-parallel: 1
       fail-fast: false
       matrix:
-        terraform_version: ${{ fromJSON(needs.versions.outputs.terraform_matrix) }}
-        provider_version: ${{ fromJSON(needs.versions.outputs.provider_matrix) }}
+        terraform_version: ${{ fromJSON(needs.variables.outputs.terraform_matrix) }}
+        provider_version: ${{ fromJSON(needs.variables.outputs.provider_matrix) }}
     name: tests-${{ matrix.terraform_version || 'latest' }}-${{ matrix.provider_version || 'latest' }}
     secrets: inherit
     uses: ./.github/workflows/acceptance-tests.yml
     with:
       terraform_version: ${{ matrix.terraform_version }}
       provider_version: ${{ matrix.provider_version }}
-      atlas_cloud_env: ${{ inputs.atlas_cloud_env || github.event.schedule == '0 0 2-31 * 0' && 'qa' || 'dev' }}
+      atlas_cloud_env: ${{ inputs.atlas_cloud_env || needs.variables.outputs.day == 'Sun' && 'qa' }}
 
   clean-after:
     needs: tests