INTMDB-572: HELP-42215 - PATCH Update Advanced Configuration Options for One Cluster / Advance Cluster (#1066)

* improve detection of empty struct

* Make cluster update when actual changes are present

Author: martinstibbe

mongodbatlas/resource_mongodbatlas_advanced_cluster.go

@@ -654,6 +654,7 @@ func resourceMongoDBAtlasAdvancedClusterUpdate(ctx context.Context, d *schema.Re
 	clusterName := ids["cluster_name"]
 
 	cluster := new(matlas.AdvancedCluster)
+	clusterChangeDetect := new(matlas.AdvancedCluster)
 
 	if d.HasChange("backup_enabled") {
 		cluster.BackupEnabled = pointy.Bool(d.Get("backup_enabled").(bool))
@@ -714,7 +715,7 @@ func resourceMongoDBAtlasAdvancedClusterUpdate(ctx context.Context, d *schema.Re
 	timeout := d.Timeout(schema.TimeoutUpdate)
 
 	// Has changes
-	if !reflect.DeepEqual(cluster, matlas.Cluster{}) {
+	if !reflect.DeepEqual(cluster, clusterChangeDetect) {
 		err := resource.RetryContext(ctx, timeout, func() *resource.RetryError {
 			_, _, err := updateAdvancedCluster(ctx, conn, cluster, projectID, clusterName, timeout)
 			if err != nil {

mongodbatlas/resource_mongodbatlas_cluster.go

@@ -804,6 +804,8 @@ func resourceMongoDBAtlasClusterUpdate(ctx context.Context, d *schema.ResourceDa
 	clusterName := ids["cluster_name"]
 
 	cluster := new(matlas.Cluster)
+	clusterChangeDetect := new(matlas.Cluster)
+	clusterChangeDetect.AutoScaling = &matlas.AutoScaling{Compute: &matlas.Compute{}}
 
 	if d.HasChange("bi_connector") {
 		cluster.BiConnector, _ = expandBiConnector(d)
@@ -939,7 +941,7 @@ func resourceMongoDBAtlasClusterUpdate(ctx context.Context, d *schema.ResourceDa
 			"cluster_name":  updatedCluster.Name,
 			"provider_name": updatedCluster.ProviderSettings.ProviderName,
 		}))
-	} else if !reflect.DeepEqual(cluster, matlas.Cluster{}) {
+	} else if !reflect.DeepEqual(cluster, clusterChangeDetect) {
 		err := resource.RetryContext(ctx, timeout, func() *resource.RetryError {
 			_, _, err := updateCluster(ctx, conn, cluster, projectID, clusterName, timeout)