fix: Skips date_format validation to allow all different formats (#3865)

* fix: Skips validation to add support for date_format values in `mongodbatlas_online_archive`

* add release notes

* fix: Update changelog to include resource prefix for date_format validation skip in mongodbatlas_online_archive

* chore: Corrects changelog message

* refactor: Rename test for invalid process region and add error message validation for date format

* fix: Add check to skip cluster destruction if an existing cluster is used

Author: EspenAlbert

.changelog/3865.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/mongodbatlas_online_archive: Removing incorrect validation for valid value `OBJECT_ID` in `date_format` field
+```

internal/service/onlinearchive/resource.go

@@ -87,10 +87,9 @@ func resourceSchema() map[string]*schema.Schema {
 						Optional: true,
 					},
 					"date_format": {
-						Type:         schema.TypeString,
-						Optional:     true,
-						Computed:     true, // api will set the default
-						ValidateFunc: validation.StringInSlice([]string{"ISODATE", "EPOCH_SECONDS", "EPOCH_MILLIS", "EPOCH_NANOSECONDS"}, false),
+						Type:     schema.TypeString,
+						Optional: true,
+						Computed: true, // api will set the default
 					},
 					"expire_after_days": {
 						Type:     schema.TypeInt,

internal/service/onlinearchive/resource_test.go

@@ -208,7 +208,7 @@ func TestAccBackupRSOnlineArchiveWithProcessRegion(t *testing.T) {
 	})
 }
 
-func TestAccBackupRSOnlineArchiveInvalidProcessRegion(t *testing.T) {
+func TestAccBackupRSOnlineArchive_ErrorMessages(t *testing.T) {
 	var (
 		clusterInfo         = acc.GetClusterInfo(t, clusterRequest())
 		clusterTerraformStr = clusterInfo.TerraformStr
@@ -221,6 +221,10 @@ func TestAccBackupRSOnlineArchiveInvalidProcessRegion(t *testing.T) {
 		ProtoV6ProviderFactories: acc.TestAccProviderV6Factories,
 		CheckDestroy:             acc.CheckDestroyCluster,
 		Steps: []resource.TestStep{
+			{
+				Config:      configWithInvalidDateFormat(clusterTerraformStr, clusterResourceName),
+				ExpectError: regexp.MustCompile("An invalid enumeration value INVALID_FORMAT was specified"),
+			},
 			{
 				Config:      configWithDataProcessRegion(clusterTerraformStr, clusterResourceName, cloudProvider, "UNKNOWN"),
 				ExpectError: regexp.MustCompile("INVALID_ATTRIBUTE"),
@@ -545,3 +549,28 @@ func TestAccOnlineArchive_deleteOnCreateTimeout(t *testing.T) {
 		},
 	})
 }
+
+func configWithInvalidDateFormat(clusterTerraformStr, clusterResourceName string) string {
+	return fmt.Sprintf(`
+	%[1]s
+	resource "mongodbatlas_online_archive" "users_archive" {
+		project_id = %[2]s.project_id
+		cluster_name = %[2]s.name
+		coll_name = "listingsAndReviews"
+		collection_type = "STANDARD"
+		db_name = "sample_airbnb"
+	
+		criteria {
+			type = "DATE"
+			date_field = "last_review"
+			date_format = "INVALID_FORMAT"
+			expire_after_days = 2
+		}
+
+		partition_fields {
+			field_name = "last_review"
+			order = 0
+		}
+	}
+	`, clusterTerraformStr, clusterResourceName)
+}

internal/testutil/acc/advanced_cluster.go

@@ -71,6 +71,9 @@ func TestStepImportCluster(resourceName string, ignorePrefixFields ...string) re
 }
 
 func CheckDestroyCluster(s *terraform.State) error {
+	if ExistingClusterUsed() {
+		return nil
+	}
 	for _, rs := range s.RootModule().Resources {
 		if rs.Type != "mongodbatlas_cluster" && rs.Type != "mongodbatlas_advanced_cluster" {
 			continue