fix: update correctly user role when collectionName is removed (#1471)

* fix: remove collectionName from user role doesn't work

* remove computed attribute and check optionality for the collection_name field.

* fix test expectations (as it should be).

Author: marcosuma

mongodbatlas/fw_resource_mongodbatlas_database_user.go

@@ -165,7 +165,6 @@ func (r *DatabaseUserRS) Schema(ctx context.Context, req resource.SchemaRequest,
 					Attributes: map[string]schema.Attribute{
 						"collection_name": schema.StringAttribute{
 							Optional: true,
-							Computed: true,
 						},
 						"database_name": schema.StringAttribute{
 							Required: true,
@@ -455,9 +454,12 @@ func newTFRolesModel(roles []matlas.Role) []tfRoleModel {
 	out := make([]tfRoleModel, len(roles))
 	for i, v := range roles {
 		out[i] = tfRoleModel{
-			RoleName:       types.StringValue(v.RoleName),
-			DatabaseName:   types.StringValue(v.DatabaseName),
-			CollectionName: types.StringValue(v.CollectionName),
+			RoleName:     types.StringValue(v.RoleName),
+			DatabaseName: types.StringValue(v.DatabaseName),
+		}
+
+		if v.CollectionName != "" {
+			out[i].CollectionName = types.StringValue(v.CollectionName)
 		}
 	}
 

mongodbatlas/fw_resource_mongodbatlas_database_user_test.go

@@ -308,6 +308,8 @@ func TestAccConfigRSDatabaseUser_withRoles(t *testing.T) {
 					resource.TestCheckResourceAttr(resourceName, "password", password),
 					resource.TestCheckResourceAttr(resourceName, "auth_database_name", "admin"),
 					resource.TestCheckResourceAttr(resourceName, "roles.#", "2"),
+					resource.TestCheckResourceAttr(resourceName, "roles.0.collection_name", "stir"),
+					resource.TestCheckResourceAttr(resourceName, "roles.1.collection_name", "unpledged"),
 				),
 			},
 			{