Skip to content

Commit defbd0f

Browse files
pitakillpitakill
authored
Update the CA certificate with a os environment (#442)
* Update the CA certificate with a os environment 1. Why is this change necessary? The certs are going to expire, so if this is a parameter from the env, is going to be more resilient. 2. How does it address the issue? These changes bring the CA certificate from an environment variable (CA_CERT) 3. What side effects does this change have? None, pure joy. :-) * Update Github Actions variables 1. Why is this change necessary? Github Actions needs a basic configuration on the repo to work 2. How does it address the issue? Add the necessary info into the repo 3. What side effects does this change have? None
1 parent 2ff8bcf commit defbd0f

File tree

3 files changed

+8
-81
lines changed

3 files changed

+8
-81
lines changed

‎.github/workflows/automated-test-acceptances.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,4 +71,5 @@ jobs:
7171
GCP_REGION_NAME: ${{ secrets.GCP_REGION_NAME }}
7272
GOOGLE_CLOUD_KEYFILE_JSON: ${{ secrets.GOOGLE_CLOUD_KEYFILE_JSON }}
7373
GCP_KEY_VERSION_RESOURCE_ID: ${{ secrets.GCP_KEY_VERSION_RESOURCE_ID }}
74+
CA_CERT: ${{ secrets.CA_CERT }}
7475
run: make testacc

‎mongodbatlas/data_source_mongodbatlas_x509_authentication_database_user_test.go‎

Lines changed: 1 addition & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -41,32 +41,7 @@ func TestAccDataSourceMongoX509AuthDBUser_basic(t *testing.T) {
4141
func TestAccDataSourceMongoX509AuthDBUser_WithCustomerX509(t *testing.T) {
4242
resourceName := "data.mongodbatlas_x509_authentication_database_user.test"
4343
projectID := os.Getenv("MONGODB_ATLAS_PROJECT_ID")
44-
cas := `
45-
-----BEGIN CERTIFICATE-----
46-
MIIEBzCCAu+gAwIBAgIUbwfQS97LZAIc/tPPVRYEWKkDETkwDQYJKoZIhvcNAQEL
47-
BQAwgZIxCzAJBgNVBAYTAkFVMQwwCgYDVQQIDANOU1cxDzANBgNVBAcMBlN5ZG5l
48-
eTEQMA4GA1UECgwHTW9uZ29EQjENMAsGA1UECwwEcm9vdDEbMBkGA1UEAwwScG9w
49-
LW9zLmxvY2FsZG9tYWluMSYwJAYJKoZIhvcNAQkBFhdlZGdhci5sb3BlekBtb25n
50-
b2RiLmNvbTAeFw0yMTAyMjIxODE4NTFaFw0yMTAzMjQxODE4NTFaMIGSMQswCQYD
51-
VQQGEwJBVTEMMAoGA1UECAwDTlNXMQ8wDQYDVQQHDAZTeWRuZXkxEDAOBgNVBAoM
52-
B01vbmdvREIxDTALBgNVBAsMBHJvb3QxGzAZBgNVBAMMEnBvcC1vcy5sb2NhbGRv
53-
bWFpbjEmMCQGCSqGSIb3DQEJARYXZWRnYXIubG9wZXpAbW9uZ29kYi5jb20wggEi
54-
MA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQClBpr0bTP5AElcNmSLC5ioMYJZ
55-
3LyBCTtcz2YDvrFoaN4UKUvD5pXTkkhSdHRgIpVbvibHQl118haj+gcN9s1GP0lb
56-
6Lz5XPOs6QdjO4fGz9M8WOPFWuAiXmDqqGhobVcSdEFtddtCPE0PAsKmzVBuDd/1
57-
RYGskzLC94f0SL9YYmF6kqXKXTH+D7JHpUWqCms3RCKIc2AYdlU0LD1dqyjabbWN
58-
I2PS4j6xQca9ZfpqlHvUxwAzLuaMAZYHDUQ++uVJi/iHY7Dd2/PA41sUT/ymwmJH
59-
4Zc4Nd73WFtYUBQxHa3sNfhiNFZ4BW6LkBGcPV6+r5AZIe3ZiEP1MuKim91XAgMB
60-
AAGjUzBRMB0GA1UdDgQWBBRTwbI8Tx+JDkNUn7k+JHZ/HHQAnTAfBgNVHSMEGDAW
61-
gBRTwbI8Tx+JDkNUn7k+JHZ/HHQAnTAPBgNVHRMBAf8EBTADAQH/MA0GCSqGSIb3
62-
DQEBCwUAA4IBAQAwObUHhCqt9UZAuqvke+HMU9FRiNehEKm+1JygZ2SQSPAnlR2S
63-
+ttihCxjyU5wVgEs8lo/VoPxtc8TfA/rKYn3xhTdqSo9nSOZVS+F8OA2A5ClnTc8
64-
U1l6t5KeQTKOsGFdyc5xzRM2P0nAY6WWB2PpFyPlwCJtPIq2l0my3W2za8m7DCLO
65-
XXJ5LYUZ8kFJKFEnS7F++A7102+tOs/GSeXwg3u9aYhhjwgsHneWzW5YLOtDqIPg
66-
ulnNdinFfGNo57BqKbRlwqdU0HIHLAZPXnftQbKMamxNw2IN169yPJPRNfdPvL/S
67-
5niRVVHHXMoEYp8L9KZ3aJQODnxY05IbTEjP
68-
-----END CERTIFICATE-----
69-
`
44+
cas := os.Getenv("CA_CERT")
7045

7146
resource.ParallelTest(t, resource.TestCase{
7247
PreCheck: func() { testAccPreCheck(t) },

‎mongodbatlas/resource_mongodbatlas_x509_authentication_database_user_test.go‎

Lines changed: 6 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -49,34 +49,9 @@ func TestAccResourceMongoDBAtlasX509AuthDBUser_basic(t *testing.T) {
4949
func TestAccResourceMongoDBAtlasX509AuthDBUser_WithCustomerX509(t *testing.T) {
5050
var (
5151
resourceName = "mongodbatlas_x509_authentication_database_user.test"
52-
cas = `
53-
-----BEGIN CERTIFICATE-----
54-
MIIEBzCCAu+gAwIBAgIUbwfQS97LZAIc/tPPVRYEWKkDETkwDQYJKoZIhvcNAQEL
55-
BQAwgZIxCzAJBgNVBAYTAkFVMQwwCgYDVQQIDANOU1cxDzANBgNVBAcMBlN5ZG5l
56-
eTEQMA4GA1UECgwHTW9uZ29EQjENMAsGA1UECwwEcm9vdDEbMBkGA1UEAwwScG9w
57-
LW9zLmxvY2FsZG9tYWluMSYwJAYJKoZIhvcNAQkBFhdlZGdhci5sb3BlekBtb25n
58-
b2RiLmNvbTAeFw0yMTAyMjIxODE4NTFaFw0yMTAzMjQxODE4NTFaMIGSMQswCQYD
59-
VQQGEwJBVTEMMAoGA1UECAwDTlNXMQ8wDQYDVQQHDAZTeWRuZXkxEDAOBgNVBAoM
60-
B01vbmdvREIxDTALBgNVBAsMBHJvb3QxGzAZBgNVBAMMEnBvcC1vcy5sb2NhbGRv
61-
bWFpbjEmMCQGCSqGSIb3DQEJARYXZWRnYXIubG9wZXpAbW9uZ29kYi5jb20wggEi
62-
MA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQClBpr0bTP5AElcNmSLC5ioMYJZ
63-
3LyBCTtcz2YDvrFoaN4UKUvD5pXTkkhSdHRgIpVbvibHQl118haj+gcN9s1GP0lb
64-
6Lz5XPOs6QdjO4fGz9M8WOPFWuAiXmDqqGhobVcSdEFtddtCPE0PAsKmzVBuDd/1
65-
RYGskzLC94f0SL9YYmF6kqXKXTH+D7JHpUWqCms3RCKIc2AYdlU0LD1dqyjabbWN
66-
I2PS4j6xQca9ZfpqlHvUxwAzLuaMAZYHDUQ++uVJi/iHY7Dd2/PA41sUT/ymwmJH
67-
4Zc4Nd73WFtYUBQxHa3sNfhiNFZ4BW6LkBGcPV6+r5AZIe3ZiEP1MuKim91XAgMB
68-
AAGjUzBRMB0GA1UdDgQWBBRTwbI8Tx+JDkNUn7k+JHZ/HHQAnTAfBgNVHSMEGDAW
69-
gBRTwbI8Tx+JDkNUn7k+JHZ/HHQAnTAPBgNVHRMBAf8EBTADAQH/MA0GCSqGSIb3
70-
DQEBCwUAA4IBAQAwObUHhCqt9UZAuqvke+HMU9FRiNehEKm+1JygZ2SQSPAnlR2S
71-
+ttihCxjyU5wVgEs8lo/VoPxtc8TfA/rKYn3xhTdqSo9nSOZVS+F8OA2A5ClnTc8
72-
U1l6t5KeQTKOsGFdyc5xzRM2P0nAY6WWB2PpFyPlwCJtPIq2l0my3W2za8m7DCLO
73-
XXJ5LYUZ8kFJKFEnS7F++A7102+tOs/GSeXwg3u9aYhhjwgsHneWzW5YLOtDqIPg
74-
ulnNdinFfGNo57BqKbRlwqdU0HIHLAZPXnftQbKMamxNw2IN169yPJPRNfdPvL/S
75-
5niRVVHHXMoEYp8L9KZ3aJQODnxY05IbTEjP
76-
-----END CERTIFICATE-----
77-
`
78-
orgID = os.Getenv("MONGODB_ATLAS_ORG_ID")
79-
projectName = acctest.RandomWithPrefix("test-acc")
52+
cas = os.Getenv("CA_CERT")
53+
orgID = os.Getenv("MONGODB_ATLAS_ORG_ID")
54+
projectName = acctest.RandomWithPrefix("test-acc")
8055
)
8156

8257
resource.ParallelTest(t, resource.TestCase{
@@ -160,33 +135,9 @@ func TestAccResourceMongoDBAtlasX509AuthDBUser_WithDatabaseUser(t *testing.T) {
160135
func TestAccResourceMongoDBAtlasX509AuthDBUser_importWithCustomerX509(t *testing.T) {
161136
var (
162137
resourceName = "mongodbatlas_x509_authentication_database_user.test"
163-
cas = `
164-
-----BEGIN CERTIFICATE-----
165-
MIIEBzCCAu+gAwIBAgIUbwfQS97LZAIc/tPPVRYEWKkDETkwDQYJKoZIhvcNAQEL
166-
BQAwgZIxCzAJBgNVBAYTAkFVMQwwCgYDVQQIDANOU1cxDzANBgNVBAcMBlN5ZG5l
167-
eTEQMA4GA1UECgwHTW9uZ29EQjENMAsGA1UECwwEcm9vdDEbMBkGA1UEAwwScG9w
168-
LW9zLmxvY2FsZG9tYWluMSYwJAYJKoZIhvcNAQkBFhdlZGdhci5sb3BlekBtb25n
169-
b2RiLmNvbTAeFw0yMTAyMjIxODE4NTFaFw0yMTAzMjQxODE4NTFaMIGSMQswCQYD
170-
VQQGEwJBVTEMMAoGA1UECAwDTlNXMQ8wDQYDVQQHDAZTeWRuZXkxEDAOBgNVBAoM
171-
B01vbmdvREIxDTALBgNVBAsMBHJvb3QxGzAZBgNVBAMMEnBvcC1vcy5sb2NhbGRv
172-
bWFpbjEmMCQGCSqGSIb3DQEJARYXZWRnYXIubG9wZXpAbW9uZ29kYi5jb20wggEi
173-
MA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQClBpr0bTP5AElcNmSLC5ioMYJZ
174-
3LyBCTtcz2YDvrFoaN4UKUvD5pXTkkhSdHRgIpVbvibHQl118haj+gcN9s1GP0lb
175-
6Lz5XPOs6QdjO4fGz9M8WOPFWuAiXmDqqGhobVcSdEFtddtCPE0PAsKmzVBuDd/1
176-
RYGskzLC94f0SL9YYmF6kqXKXTH+D7JHpUWqCms3RCKIc2AYdlU0LD1dqyjabbWN
177-
I2PS4j6xQca9ZfpqlHvUxwAzLuaMAZYHDUQ++uVJi/iHY7Dd2/PA41sUT/ymwmJH
178-
4Zc4Nd73WFtYUBQxHa3sNfhiNFZ4BW6LkBGcPV6+r5AZIe3ZiEP1MuKim91XAgMB
179-
AAGjUzBRMB0GA1UdDgQWBBRTwbI8Tx+JDkNUn7k+JHZ/HHQAnTAfBgNVHSMEGDAW
180-
gBRTwbI8Tx+JDkNUn7k+JHZ/HHQAnTAPBgNVHRMBAf8EBTADAQH/MA0GCSqGSIb3
181-
DQEBCwUAA4IBAQAwObUHhCqt9UZAuqvke+HMU9FRiNehEKm+1JygZ2SQSPAnlR2S
182-
+ttihCxjyU5wVgEs8lo/VoPxtc8TfA/rKYn3xhTdqSo9nSOZVS+F8OA2A5ClnTc8
183-
U1l6t5KeQTKOsGFdyc5xzRM2P0nAY6WWB2PpFyPlwCJtPIq2l0my3W2za8m7DCLO
184-
XXJ5LYUZ8kFJKFEnS7F++A7102+tOs/GSeXwg3u9aYhhjwgsHneWzW5YLOtDqIPg
185-
ulnNdinFfGNo57BqKbRlwqdU0HIHLAZPXnftQbKMamxNw2IN169yPJPRNfdPvL/S
186-
5niRVVHHXMoEYp8L9KZ3aJQODnxY05IbTEjP
187-
-----END CERTIFICATE-----`
188-
orgID = os.Getenv("MONGODB_ATLAS_ORG_ID")
189-
projectName = acctest.RandomWithPrefix("test-acc")
138+
cas = os.Getenv("CA_CERT")
139+
orgID = os.Getenv("MONGODB_ATLAS_ORG_ID")
140+
projectName = acctest.RandomWithPrefix("test-acc")
190141
)
191142

192143
resource.ParallelTest(t, resource.TestCase{

0 commit comments

Comments
 (0)