fix: fixes a bug for issue 289 (#323)

* fix: fixes a bug for issue 289

* added skip test for one testacc for terraform workflow reasons

* added env var in github actions

Co-authored-by: Edgar López <[email protected]>

Author: coderGo93

.github/workflows/automated-test-acceptances.yml

@@ -33,6 +33,7 @@ jobs:
         env:
           SKIP_TEST_EXTERNAL_CREDENTIALS: ${{ secrets.SKIP_TEST_EXTERNAL_CREDENTIALS }}
           SKIP_TEST_IMPORT: ${{ secrets.SKIP_TEST_IMPORT }}
+          SKIP_TEST: ${{ secrets.SKIP_TEST }}
           MONGODB_ATLAS_PUBLIC_KEY: ${{ secrets.MONGODB_ATLAS_PUBLIC_KEY }}
           MONGODB_ATLAS_PRIVATE_KEY: ${{ secrets.MONGODB_ATLAS_PRIVATE_KEY }}
           MONGODB_ATLAS_PROJECT_ID: ${{ secrets.MONGODB_ATLAS_PROJECT_ID }}

mongodbatlas/provider_test.go

@@ -161,3 +161,9 @@ func checkTeamsIds(t *testing.T) {
 		t.Fatal("`MONGODB_ATLAS_TEAMS_IDS` must be set for Projects acceptance testing")
 	}
 }
+
+func SkipTest(t *testing.T) {
+	if strings.EqualFold(os.Getenv("SKIP_TEST"), "true") {
+		t.Skip()
+	}
+}

mongodbatlas/resource_mongodbatlas_cluster_test.go

@@ -60,6 +60,7 @@ func TestAccResourceMongoDBAtlasCluster_basicAWS(t *testing.T) {
 }
 
 func TestAccResourceMongoDBAtlasCluster_basicAWS_instanceScale(t *testing.T) {
+	SkipTest(t) // Skipped for now because of paramater provider_disk_iops breaks the terraform flow
 	var (
 		cluster      matlas.Cluster
 		resourceName = "mongodbatlas_cluster.test"
@@ -957,7 +958,7 @@ func testAccMongoDBAtlasClusterConfigAWSNVMEInstance(projectID, name, backupEnab
 
 			// Provider Settings "block"
 			provider_name               = "AWS"
-			provider_disk_iops 		    = 3000
+			provider_disk_iops 		    = 300
 			provider_encrypt_ebs_volume = false
 			provider_volume_type        = "PROVISIONED"
 			provider_instance_size_name = "M40_NVME"

mongodbatlas/resource_mongodbatlas_maintenance_window.go

@@ -140,6 +140,10 @@ func resourceMongoDBAtlasMaintenanceWindowRead(d *schema.ResourceData, meta inte
 		return fmt.Errorf(errorMaintenanceRead, d.Id(), err)
 	}
 
+	if err := d.Set("project_id", d.Id()); err != nil {
+		return fmt.Errorf(errorMaintenanceRead, d.Id(), err)
+	}
+
 	return nil
 }
 

mongodbatlas/resource_mongodbatlas_maintenance_window_test.go

@@ -95,11 +95,10 @@ func TestAccResourceMongoDBAtlasMaintenanceWindow_importBasic(t *testing.T) {
 				),
 			},
 			{
-				ResourceName:            resourceName,
-				ImportStateIdFunc:       testAccCheckMongoDBAtlasMaintenanceWindowImportStateIDFunc(resourceName),
-				ImportState:             true,
-				ImportStateVerify:       true,
-				ImportStateVerifyIgnore: []string{"project_id"},
+				ResourceName:      resourceName,
+				ImportStateIdFunc: testAccCheckMongoDBAtlasMaintenanceWindowImportStateIDFunc(resourceName),
+				ImportState:       true,
+				ImportStateVerify: true,
 			},
 		},
 	})